Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to current firedrake #20

Merged
merged 13 commits into from
Apr 12, 2024
Merged

Conversation

JaroslavHron
Copy link
Contributor

make firedrake-ts usable with current firedrake

  • make _TSContext as subclass of _SNESContext to reduce some code duplications
  • deal with new notion of cofunction in UFL/firedrake
  • modify some examples to run
  • bump firedrake-ts to version 0.2

@IvanYashchuk
Copy link
Owner

Hey Jaroslav! Thanks a lot for updating the code. The CI doesn't work for some reason, I'll take a look at this and I'll review the changes later today.
That reminds me as well to take a look at #19 which I'll do also today.

@JaroslavHron JaroslavHron mentioned this pull request Apr 12, 2024
Copy link
Owner

@IvanYashchuk IvanYashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot for keeping the project up-to-date!

v[:]=0.63 + 0.2*(0.5-rng.random(v.size))


pc = "lu" #"fieldsplit"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fieldsplit preconditioner not working anymore?

from pyop2 import op2
import numpy as np
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to pyop2?

@IvanYashchuk IvanYashchuk merged commit 1186966 into IvanYashchuk:master Apr 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants