Add support for complex top-level objects #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, json2md only accessed the first element of the top-level object in the JSON file. That is fine if the JSON file follows a strictly hierarchical structure (as in the HTML examples), but fails if there is a more complex structure. This commit changes this behaviour (at least for the synchronous part) and now traverses all object keys at the top level, concatenating the results as we go along.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, json2md only accessed the first element of the top-level
object in the JSON file. That is fine if the JSON file follows a
strictly hierarchical structure (as in the HTML examples), but fails
if there is a more complex structure.
This commit changes this behaviour (at least for the synchronous part)
and now traverses all object keys at the top level, concatenating the
results as we go along.