Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add debug_protocol::build_command() #10261

Merged
merged 24 commits into from
Mar 1, 2022
Merged

add debug_protocol::build_command() #10261

merged 24 commits into from
Mar 1, 2022

Conversation

SamerKhshiboun
Copy link
Contributor

@SamerKhshiboun SamerKhshiboun commented Feb 23, 2022 •
edited
Loading

  • add build_raw_data to the debug_protocol API - (this API generates a raw data cmd from opcode, params, and data)
  • add the new API to C# and Python wrappers
  • add build_raw_data python unit-test under unit_tests/debug_protocol/
  • fix old tests/scenarios to use this new API

@SamerKhshiboun
- add build_raw_data to the debug_protocol API
89db482 
- add the new API to C# and Python wrappers
- add python unit-test under unit_tests/debug_protocol/
- fix old tests/scenarios to use this new API
- fix some formatting in python files to meet PEP8 coding style
@SamerKhshiboun
Merge branch 'development' of https://github.com/IntelRealSense/libre…
1c582c9 
…alsense into buildRawData
@SamerKhshiboun
Merge branch 'development' of https://github.com/IntelRealSense/libre…
9b211cd 
…alsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
d9da3dd 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
582c874 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
b15b03b 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
9b5b703 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
fe32be5 
…ealsense into buildRawData
@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review February 23, 2022 15:40
maloel
maloel reviewed Feb 24, 2022
View reviewed changes
src/hw-monitor.cpp Outdated Show resolved Hide resolved
maloel
maloel reviewed Feb 24, 2022
View reviewed changes
src/hw-monitor.cpp Outdated Show resolved Hide resolved
maloel
maloel reviewed Feb 24, 2022
View reviewed changes
src/rs.cpp Outdated Show resolved Hide resolved
maloel
maloel reviewed Feb 24, 2022
View reviewed changes
src/rs.cpp Outdated Show resolved Hide resolved
maloel
maloel reviewed Mar 1, 2022
View reviewed changes
src/core/debug.h Outdated Show resolved Hide resolved
maloel
maloel reviewed Mar 1, 2022
View reviewed changes
src/core/debug.h Outdated Show resolved Hide resolved
maloel
maloel reviewed Mar 1, 2022
View reviewed changes
src/core/debug.h Outdated Show resolved Hide resolved
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
944ae44 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
480c848 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
5eaf899 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
d98038f 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
4e7050a 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
8086827 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
612a605 
…ealsense into buildRawData
@SamerKhshiboun
Merge branch 'buildRawData' of https://github.com/SamerKhshiboun/libr…
8c76d84 
…ealsense into buildRawData
@maloel maloel changed the title add build_raw_data functionality to debug_protocol interface add debug_protocol::build_command() Mar 1, 2022
@maloel maloel merged commit 636645b into IntelRealSense:development Mar 1, 2022
@SamerKhshiboun SamerKhshiboun mentioned this pull request Mar 2, 2022
Merged
maloel added a commit that referenced this pull request Mar 2, 2022
@maloel
PR #10279 from Samer: Fix unit tests related to PR #10261 change
ea15fcd
@maloel maloel mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloel maloel maloel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamerKhshiboun @maloel