Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update faiss version in both Dockerfiles and any required API updates #251

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Update faiss version in both Dockerfiles and any required API updates #251

wants to merge 10 commits into from

Conversation

cwlacewe
Copy link
Contributor

@cwlacewe cwlacewe commented Nov 6, 2024

Closes #222

Updating Faiss from v1.7.4 to v1.9.0
Add any necessary API updates

@cwlacewe cwlacewe linked an issue Nov 6, 2024 that may be closed by this pull request
Upgrade FAISS version #222
Open
@cwlacewe cwlacewe added this to the v2.11.0 Tasks milestone Nov 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Target CPP Coverage: 64.1637%
Source CPP Coverage: 64.1637%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@cwlacewe cwlacewe changed the title Update faiss version in both Dockerfiles Update faiss version in both Dockerfiles and any required API updates Nov 13, 2024
@github-actions GitHub Actions
Copy link

Target CPP Coverage: 64.1609%
Source CPP Coverage: 64.1609%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Target CPP Coverage: 64.1609%
Source CPP Coverage: 64.1421%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Target CPP Coverage: 64.1609%
Source CPP Coverage: 64.1323%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Target CPP Coverage: 64.1609%
Source CPP Coverage: 64.1519%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Target CPP Coverage: 64.1609%
Source CPP Coverage: 64.1421%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Target CPP Coverage: 64.1609%
Source CPP Coverage: 64.1323%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Target CPP Coverage: 64.1609%
Source CPP Coverage: 64.1421%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Target CPP Coverage: 64.1609%
Source CPP Coverage: 64.1421%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

@cwlacewe
Copy link
Contributor Author

@s-gobriel, code changes look good to me. You can mark as Ready to review and get Keira to approve and merge.

@github-actions GitHub Actions
Copy link

Target CPP Coverage: 64.1609%
Source CPP Coverage: 64.1421%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@s-gobriel s-gobriel

Labels
None yet
Projects
None yet
Milestone
v2.11.0 Tasks
Development

Successfully merging this pull request may close these issues.

Upgrade FAISS version
3 participants
@cwlacewe @s-gobriel @sys-vdms