Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conditional content-security-policy header #160

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

cgorman
Copy link
Collaborator

@cgorman cgorman commented Jul 20, 2023

If any of the URLs start with https then we add the
Content-Security-Policy : upgrade-insecure-requests header to
DICOMwebClient requests. Addresses #159

If any of the URLs start with https then we add the
Content-Security-Policy : upgrade-insecure-requests header to
DICOMwebClient requests. Addresses #159
@cgorman cgorman requested a review from igoroctaviano July 20, 2023 16:54
@cgorman cgorman added bug Something isn't working idc:priority Priority for the NCI's Imaging Data Commons labels Jul 20, 2023
@cgorman
Copy link
Collaborator Author

cgorman commented Jul 20, 2023

Let me know if there's a better way of doing this, thanks!

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Visit the preview URL for this PR (updated for commit c48584a):

https://idc-external-006--pr160-dev-cg-upgrade-insec-409byuig.web.app

(expires Thu, 27 Jul 2023 19:29:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

Copy link
Collaborator

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a single JSON.stringify(serverSettings).includes('https') would be enough to set this header. I'm not sure if this should be here though, maybe we need to add this change to dicomweb-client?

@igoroctaviano igoroctaviano self-requested a review November 1, 2024 18:26
Copy link
Collaborator

@igoroctaviano igoroctaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igoroctaviano igoroctaviano merged commit 3a6979e into master Nov 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working idc:priority Priority for the NCI's Imaging Data Commons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants