Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up example #5

Merged
merged 2 commits into from
May 30, 2024
Merged

Clean up example #5

merged 2 commits into from
May 30, 2024

Conversation

spectranaut
Copy link
Collaborator

No description provided.

@spectranaut spectranaut force-pushed the cleanup-testdriver branch from 07a64ba to 37b4e8b Compare May 29, 2024 19:29
@spectranaut spectranaut requested a review from alice May 29, 2024 19:29
@spectranaut spectranaut force-pushed the cleanup-testdriver branch from 37b4e8b to 2d15cba Compare May 29, 2024 19:31
@spectranaut spectranaut force-pushed the cleanup-testdriver branch from 2d15cba to c80d378 Compare May 29, 2024 19:34
@alice alice merged commit de8626e into acacia-test-testdriver May 30, 2024
schenney-chromium pushed a commit that referenced this pull request Jul 15, 2024
Since @page border box layout objects aren't in the the layout tree, any
code that wants to walk up the tree to find the containing block will be
in for a surprise.

This would happen if percentage-based @page padding was used [1].
Recomputing padding during painting when we have already done it during
layout is rather pointless anyway. Read it out directly from the
fragment.

[1] #1 blink::LayoutBox::ContainingBlockLogicalWidthForContent()
    #2 blink::LayoutBoxModelObject::ComputedCSSPadding()
    #3 blink::LayoutBoxModelObject::PaddingTop()
    #4 blink::LayoutBoxModelObject::PaddingOutsets()
    #5 blink::BoxPainterBase::PaintFillLayer()
    #6 blink::BoxPainterBase::PaintFillLayers()
    #7 blink::BoxFragmentPainter::PaintBackground()

Bug: 40286153
Change-Id: I1e6e92c2ce1d81aab2673ec9a877eac455534102
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526469
Commit-Queue: Morten Stenshorne <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1300711}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants