Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve several issues #21

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: resolve several issues #21

merged 1 commit into from
May 29, 2024

Conversation

Gorter-dev
Copy link
Contributor

Closes
#8
#10
#15
#19

Copy link

@freekvandeven freekvandeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the firebase instance should be in the constructor of the notifications service

@freekvandeven freekvandeven added the enhancement New feature or request label May 29, 2024
Copy link

@freekvandeven freekvandeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove the test folder in the root and the pubspec.yaml. You could add a melos.yaml from another component if you want to indicate that it is a monorepo

@Gorter-dev Gorter-dev force-pushed the 1.4.0 branch 2 times, most recently from c838094 to 90df385 Compare May 29, 2024 11:38
LICENSE Outdated Show resolved Hide resolved
@Gorter-dev Gorter-dev force-pushed the 1.4.0 branch 3 times, most recently from f0406e6 to 7d9ac45 Compare May 29, 2024 11:49
@freekvandeven freekvandeven self-requested a review May 29, 2024 11:52
@Gorter-dev Gorter-dev force-pushed the 1.4.0 branch 2 times, most recently from d253e50 to 8e93b5d Compare May 29, 2024 12:03
@Gorter-dev Gorter-dev force-pushed the 1.4.0 branch 2 times, most recently from 5ab883e to 194449e Compare May 29, 2024 13:24
@Gorter-dev Gorter-dev merged commit 03d4305 into master May 29, 2024
1 check passed
@Gorter-dev Gorter-dev deleted the 1.4.0 branch May 29, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants