Merge pull request #25 from Iconica-Development/bugfix/notification_c…

…enter fix: styling and service
Iconica-Development · Jul 18, 2024 · 2acb617 · 2acb617
2 parents 1692281 + b929ff5
commit 2acb617
Show file tree

Hide file tree

Showing 13 changed files with 39 additions and 134 deletions.
diff --git a/packages/flutter_notification_center/example/lib/custom_notification.dart b/packages/flutter_notification_center/example/lib/custom_notification.dart
@@ -6,14 +6,12 @@ import 'package:flutter_notification_center_firebase/flutter_notification_center
 
 class CustomNotificationWidget extends StatelessWidget {
   final NotificationModel notification;
-  final NotificationStyle style;
   final FirebaseNotificationService notificationService;
   final NotificationTranslations notificationTranslations;
   final BuildContext context;
 
   const CustomNotificationWidget({
     required this.notification,
-    required this.style,
     required this.notificationTranslations,
     required this.notificationService,
     required this.context,
@@ -56,26 +54,18 @@ class CustomNotificationWidget extends StatelessWidget {
               onTap: () async =>
                   _navigateToNotificationDetail(context, notification),
               child: ListTile(
-                leading: style.showNotificationIcon != null
-                    ? Icon(
-                        notification.icon,
-                        color: style.leadingIconColor,
-                      )
-                    : null,
                 title: Row(
                   crossAxisAlignment: CrossAxisAlignment.start,
                   children: [
                     Expanded(
                       child: Text(
                         notification.title,
-                        style: style.titleTextStyle,
                       ),
                     ),
                   ],
                 ),
                 trailing: IconButton(
                   icon: const Icon(Icons.push_pin),
-                  color: style.pinnedIconColor,
                   onPressed: () async =>
                       _navigateToNotificationDetail(context, notification),
                   padding: const EdgeInsets.only(left: 60.0),
@@ -147,9 +137,8 @@ class CustomNotificationWidget extends StatelessWidget {
                         margin: const EdgeInsets.only(right: 8.0),
                         width: 12.0,
                         height: 12.0,
-                        decoration: BoxDecoration(
+                        decoration: const BoxDecoration(
                           shape: BoxShape.circle,
-                          color: style.isReadDotColor,
                         ),
                       )
                     : null,
@@ -170,7 +159,6 @@ class CustomNotificationWidget extends StatelessWidget {
           builder: (context) => NotificationDetailPage(
             translations: notificationTranslations,
             notification: notification,
-            notificationStyle: style,
           ),
         ),
       );

diff --git a/packages/flutter_notification_center/example/lib/main.dart b/packages/flutter_notification_center/example/lib/main.dart
@@ -63,21 +63,6 @@ class _NotificationCenterDemoState extends State<NotificationCenterDemo> {
       notificationWidgetBuilder: (notification, context) =>
           CustomNotificationWidget(
         notification: notification,
-        style: const NotificationStyle(
-          appTitleTextStyle: TextStyle(
-            color: Colors.black,
-            fontSize: 20,
-          ),
-          titleTextStyle: TextStyle(
-            color: Colors.black,
-            fontWeight: FontWeight.w400,
-            fontSize: 16,
-          ),
-          leadingIconColor: Colors.grey,
-          pinnedIconColor: Colors.grey,
-          isReadDotColor: Colors.red,
-          showNotificationIcon: true,
-        ),
         notificationService: service,
         notificationTranslations: const NotificationTranslations.empty(),
         context: context,

diff --git a/packages/flutter_notification_center/example/pubspec.yaml b/packages/flutter_notification_center/example/pubspec.yaml
@@ -18,13 +18,13 @@ dependencies:
     git:
       url: https://github.com/Iconica-Development/flutter_notification_center
       path: packages/flutter_notification_center
-      ref: 2.0.0
+      ref: 3.0.0
 
   flutter_notification_center_firebase:
     git:
       url: https://github.com/Iconica-Development/flutter_notification_center
       path: packages/flutter_notification_center_firebase
-      ref: 2.0.0
+      ref: 3.0.0
 
 dev_dependencies:
   flutter_test:

diff --git a/packages/flutter_notification_center/lib/flutter_notification_center.dart b/packages/flutter_notification_center/lib/flutter_notification_center.dart
@@ -6,7 +6,6 @@ export "package:flutter_animated_widgets/flutter_animated_widgets.dart";
 
 export "src/models/notification.dart";
 export "src/models/notification_config.dart";
-export "src/models/notification_theme.dart";
 export "src/models/notification_translation.dart";
 export "src/notification_bell.dart";
 export "src/notification_bell_story.dart";

diff --git a/packages/flutter_notification_center/lib/src/models/notification_config.dart b/packages/flutter_notification_center/lib/src/models/notification_config.dart
@@ -17,6 +17,8 @@ class NotificationConfig {
     this.showAsSnackBar = true,
     this.enableNotificationPopups = true,
     this.bellStyle = const AnimatedNotificationBellStyle(),
+    this.pinnedIconColor = Colors.black,
+    this.emptyNotificationsBuilder,
   });
 
   /// The notification service to use for delivering notifications.
@@ -38,4 +40,10 @@ class NotificationConfig {
 
   /// The style of the notification bell.
   final AnimatedNotificationBellStyle bellStyle;
+
+  /// The color of the trailing icon (if any) in the notification.
+  final Color? pinnedIconColor;
+
+  /// A builder function to display when there are no notifications.
+  final Widget Function()? emptyNotificationsBuilder;
 }
diff --git a/packages/flutter_notification_center/lib/src/models/notification_theme.dart b/packages/flutter_notification_center/lib/src/models/notification_theme.dart
diff --git a/packages/flutter_notification_center/lib/src/models/notification_translation.dart b/packages/flutter_notification_center/lib/src/models/notification_translation.dart
@@ -14,7 +14,7 @@ class NotificationTranslations {
   });
 
   const NotificationTranslations.empty({
-    this.appBarTitle = "Notifications",
+    this.appBarTitle = "notifications",
     this.noNotifications = "No unread notifications available.",
     this.notificationDismissed = "Notification dismissed.",
     this.notificationPinned = "Notification pinned.",

diff --git a/packages/flutter_notification_center/lib/src/notification_bell.dart b/packages/flutter_notification_center/lib/src/notification_bell.dart
@@ -46,6 +46,7 @@ class _NotificationBellState extends State<NotificationBell> {
 
   @override
   Widget build(BuildContext context) => IconButton(
+        padding: EdgeInsets.zero,
         onPressed: widget.onTap,
         icon: AnimatedNotificationBell(
           duration: const Duration(seconds: 1),

diff --git a/packages/flutter_notification_center/lib/src/notification_center.dart b/packages/flutter_notification_center/lib/src/notification_center.dart
@@ -48,12 +48,11 @@ class NotificationCenterState extends State<NotificationCenter> {
   Widget build(BuildContext context) {
     var theme = Theme.of(context);
     return Scaffold(
-      backgroundColor: theme.colorScheme.surface,
       appBar: AppBar(
         backgroundColor: theme.appBarTheme.backgroundColor,
         title: Text(
           widget.config.translations.appBarTitle,
-          style: theme.appBarTheme.titleTextStyle,
+          style: theme.textTheme.headlineLarge,
         ),
         centerTitle: true,
         iconTheme: theme.appBarTheme.iconTheme ??
@@ -76,9 +75,13 @@ class NotificationCenterState extends State<NotificationCenter> {
             debugPrint("Error: ${snapshot.error}");
             return Center(child: Text(widget.config.translations.errorMessage));
           } else if (snapshot.data == null || snapshot.data!.isEmpty) {
-            return Center(
-              child: Text(widget.config.translations.noNotifications),
-            );
+            return widget.config.emptyNotificationsBuilder?.call() ??
+                Center(
+                  child: Text(
+                    widget.config.translations.noNotifications,
+                    style: theme.textTheme.bodyMedium,
+                  ),
+                );
           } else {
             return ListView.builder(
               padding: const EdgeInsets.symmetric(
@@ -95,7 +98,6 @@ class NotificationCenterState extends State<NotificationCenter> {
                           notification,
                           widget.config.service,
                           widget.config.translations,
-                          const NotificationStyle(),
                         ),
                         child: Dismissible(
                           key: Key("${notification.id}_pinned"),
@@ -154,6 +156,7 @@ class NotificationCenterState extends State<NotificationCenter> {
                           child: _notificationItem(
                             context,
                             notification,
+                            widget.config,
                           ),
                         ),
                       )
@@ -163,7 +166,6 @@ class NotificationCenterState extends State<NotificationCenter> {
                           notification,
                           widget.config.service,
                           widget.config.translations,
-                          const NotificationStyle(),
                         ),
                         child: Dismissible(
                           key: Key(notification.id),
@@ -225,6 +227,7 @@ class NotificationCenterState extends State<NotificationCenter> {
                           child: _notificationItem(
                             context,
                             notification,
+                            widget.config,
                           ),
                         ),
                       );
@@ -240,6 +243,7 @@ class NotificationCenterState extends State<NotificationCenter> {
 Widget _notificationItem(
   BuildContext context,
   NotificationModel notification,
+  NotificationConfig config,
 ) {
   var theme = Theme.of(context);
   var dateTimePushed =
@@ -267,7 +271,7 @@ Widget _notificationItem(
                     const Icon(
                       Icons.circle_rounded,
                       color: Colors.black,
-                      size: 10,
+                      size: 8,
                     ),
                     const SizedBox(
                       width: 8,
@@ -283,7 +287,7 @@ Widget _notificationItem(
                       notification.isRead
                           ? Icons.push_pin_outlined
                           : Icons.push_pin,
-                      color: Colors.black,
+                      color: config.pinnedIconColor,
                       size: 30,
                     ),
                   ),
@@ -293,15 +297,15 @@ Widget _notificationItem(
                 ],
                 Text(
                   notification.title,
-                  style: notification.isRead
+                  style: notification.isRead && !notification.isPinned
                       ? theme.textTheme.bodyMedium
-                      : theme.textTheme.bodyLarge,
+                      : theme.textTheme.titleMedium,
                 ),
               ],
             ),
             Text(
               dateTimePushed,
-              style: theme.textTheme.bodyMedium,
+              style: theme.textTheme.labelSmall,
             ),
           ],
         ),
@@ -315,7 +319,6 @@ Future<void> _navigateToNotificationDetail(
   NotificationModel notification,
   NotificationService notificationService,
   NotificationTranslations notificationTranslations,
-  NotificationStyle style,
 ) async {
   if (context.mounted) {
     await Navigator.push(
@@ -324,7 +327,6 @@ Future<void> _navigateToNotificationDetail(
         builder: (context) => NotificationDetailPage(
           translations: notificationTranslations,
           notification: notification,
-          notificationStyle: style,
         ),
       ),
     );

diff --git a/packages/flutter_notification_center/lib/src/notification_detail.dart b/packages/flutter_notification_center/lib/src/notification_detail.dart
@@ -11,15 +11,11 @@ class NotificationDetailPage extends StatelessWidget {
   /// The [notification] parameter specifies the notification
   ///  to display details for.
   const NotificationDetailPage({
-    required this.notificationStyle,
     required this.notification,
     required this.translations,
     super.key,
   });
 
-  /// The notification style.
-  final NotificationStyle notificationStyle;
-
   /// The notification to display details for.
   final NotificationModel notification;
 
@@ -30,12 +26,11 @@ class NotificationDetailPage extends StatelessWidget {
   Widget build(BuildContext context) {
     var theme = Theme.of(context);
     return Scaffold(
-      backgroundColor: theme.colorScheme.surface,
       appBar: AppBar(
         backgroundColor: theme.appBarTheme.backgroundColor,
         title: Text(
           translations.appBarTitle,
-          style: theme.appBarTheme.titleTextStyle,
+          style: theme.textTheme.headlineLarge,
         ),
         iconTheme: theme.appBarTheme.iconTheme ??
             const IconThemeData(color: Colors.white),
@@ -57,23 +52,20 @@ class NotificationDetailPage extends StatelessWidget {
             children: [
               Text(
                 notification.title,
-                style: notificationStyle.titleTextStyle ?? const TextStyle(),
+                style: theme.textTheme.titleMedium,
               ),
               const SizedBox(height: 10),
               Text(
                 notification.body,
-                style: notificationStyle.subtitleTextStyle ?? const TextStyle(),
+                style: theme.textTheme.bodyMedium,
               ),
               const SizedBox(height: 10),
               Text(
                 "${translations.datePrefix}"
                 ' ${DateFormat('yyyy-MM-dd HH:mm').format(
                   notification.dateTimePushed ?? DateTime.now(),
                 )}',
-                style: const TextStyle(
-                  fontSize: 12,
-                  color: Colors.grey,
-                ),
+                style: theme.textTheme.labelSmall,
               ),
             ],
           ),