Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump minimum node version to 16 #582

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix: bump minimum node version to 16 #582

merged 1 commit into from
Apr 13, 2023

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Apr 13, 2023 •
edited
Loading

PR summary

This commit modifies the validator's startup script (packages/validator/src/cli-validator/index.js) so that it requires node 16 as the minimum version of the runtime. We had previously updated the package.json to cover the install-related steps.

PR Checklist

General checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Dependencies have been updated as needed
  • .secrets.baseline updated as needed?

Checklist for adding a new validation rule:

  • Added new validation rule definition (packages/ruleset/src/rules/*.js, index.js)
  • If necessary, added new validation rule implementation (packages/ruleset/src/functions/*.js, updated index.js)
  • Added new rule to default configuration (packages/ruleset/src/ibm-oas.js)
  • Added tests for new rule (packages/ruleset/test/*.test.js)
  • Added docs for new rule (docs/ibm-cloud-rules.md)

@padamstx
feat: bump minimum node version to 16
97741f2 
This commit modifies the validator's startup script
(packages/validator/src/cli-validator/index.js) so that
it requires node 16 as the minimum version of the runtime.
We had previously updated the package.json to cover the
install-related steps.

Signed-off-by: Phil Adams <[email protected]>
@padamstx padamstx self-assigned this Apr 13, 2023
@padamstx padamstx requested a review from dpopp07 April 13, 2023 14:22
@padamstx
Copy link
Member Author

It seemed like this change should be a "feat" type commit, but happy to change that if needed.
Normally this type of change might be a feat, but we already were requiring node 16 during install, so maybe this change just amounts to a "fix"?

@dpopp07
Copy link
Member

dpopp07 commented Apr 13, 2023

we already were requiring node 16 during install, so maybe this change just amounts to a "fix"?

I think that's right, let's call it a "fix"

dpopp07
dpopp07 approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's use a "fix" commit, as discussed in the comments

@padamstx padamstx changed the title feat: bump minimum node version to 16 fix: bump minimum node version to 16 Apr 13, 2023
@padamstx padamstx merged commit 7849314 into main Apr 13, 2023
@padamstx padamstx deleted the bump-min-node branch April 13, 2023 14:48
ibm-devx-sdk pushed a commit that referenced this pull request Apr 13, 2023
@semantic-release-bot
chore(release): 1.0.3 [skip ci]
ab31eab 
## ibm-openapi-validator [1.0.3](https://github.com/IBM/openapi-validator/compare/[email protected]@1.0.3) (2023-04-13)

### Bug Fixes

* bump minimum node version to 16 ([#582](#582)) ([7849314](7849314))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.0.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ibm-devx-sdk
Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpopp07 dpopp07 dpopp07 approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@padamstx @dpopp07 @ibm-devx-sdk