Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle the error during gzip compression instead of panic #137

Merged
merged 2 commits into from
Aug 31, 2021
Merged

fix: handle the error during gzip compression instead of panic #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27fa2b7
fix: handle the error during gzip compression instead of panic
pyrooka Aug 31, 2021
db31813
chore: discard return value to make the linter happy
pyrooka Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion v5/core/gzip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func NewGzipCompressionReader(uncompressedReader io.Reader) (io.Reader, error) {
// to the pipe only when the pipe reader is called to retrieve more bytes.
_, err := io.Copy(compressedWriter, uncompressedReader)
if err != nil {
panic(err)
_ = pipeWriter.CloseWithError(err)
}
}()
return pipeReader, nil
Expand Down