Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of Waybill#accountingInformation #231

Open
lambertciata opened this issue Mar 27, 2024 · 1 comment · Fixed by #273
Open

Review of Waybill#accountingInformation #231

lambertciata opened this issue Mar 27, 2024 · 1 comment · Fixed by #273
Labels
Ontology

Comments

@lambertciata
Copy link
Collaborator

In XFWB the includedAccountingNote is an array with 2 fields (Code related to Code List 1.30 and Content).

Currently in the ontology we have one data property which is a string.

Assess whether we:

  • Change the data type to align with XFWB requirements
  • Describe that all details should be filled in the current Waybill#accountingInformation with some conversion guidelines
@lambertciata lambertciata converted this from a draft issue Mar 27, 2024
@lambertciata lambertciata moved this from Backlog to Approval from taskforce in Data Model Changes Jul 16, 2024
@lambertciata
Copy link
Collaborator Author

As 2 fields are actually used, it was decided to split accoutingInformation in 2 fields.

That way we will have accoutingInformation (0:n) as an embedded object with 2 properties "informationIdentifier" and "InformationText"

nscheiber-champ added a commit to nscheiber-champ/ONE-Record that referenced this issue Oct 18, 2024
@nscheiber-champ
DM update as per DMWG 17/10/2024
1c70148 
- Added temperatureInstructions to Piece
 (IATA-Cargo#227)
- Added new property textualPostalCode to Address (IATA-Cargo#221)
- Added new property operatingParties to TransportMovement (IATA-Cargo#229)
- Added new class AccountingNote (IATA-Cargo#231)
- Added new property accountingNoteIdentifier to AccountingNote (IATA-Cargo#231)
- Added new property accountingNoteText to AccountingNote (IATA-Cargo#231)
- Added new property accountingNotes to Waybill (IATA-Cargo#231)
- Added new property taxAmount to Waybill (IATA-Cargo#247) - max 1, CurrencyValue
- Added new property locationIndicator to OtherCharge (IATA-Cargo#247) - max 1, Location
- Added new property reasonDescription to OtherCharge (IATA-Cargo#247) - max 1, string
- Added new property chargeQuantity to OtherCharge (IATA-Cargo#247) - max 1, double
- Deprecated postalCode in favor of textualPostalCode (IATA-Cargo#221)
- Deprecated accountingInformation in favor of AccountingNote and included properties (IATA-Cargo#231)
- Removed specialHandlingCodes from Shipment (IATA-Cargo#228)
- Changed value of partyDetails from Organization to LogisticsAgent (IATA-Cargo#222)
- Lifted cardinality restriction on regulatedEntityAcceptor in SecurityDeclaration (IATA-Cargo#244)
@nscheiber-champ nscheiber-champ mentioned this issue Oct 18, 2024
Merged
@lambertciata lambertciata linked a pull request Nov 29, 2024 that will close this issue
DM update as per DMWG 17/10/2024 #273
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Ontology
Projects
Data Model Changes
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DM update as per DMWG 17/10/2024 nscheiber-champ/ONE-Record
1 participant
@lambertciata