Add regexp for better error handling in addauthor (orcide, inst, email) #238
Conversation
|
Do we need more checks or tests? |
| } | ||
| \cs_new_eq:NN \IfValidInst \iacr_check_inst:nTF | ||
|
|
||
| \prg_new_conditional:Npnn \iacr_check_email:n #1 { T, F, TF } |
There was a problem hiding this comment.
I'm not convinced that we should check email addresses. Some people may like to put firstname dot lastname to obfuscate it, and I don't think we should interfere with that. The only purpose of the email address in the paper is to allow readers to contact at least one author, but we don't use it for any other registration (there is a separate validated email address from hotcrp when the corresponding author uploads their final version). It's also really complicated to recognize 100% of email addresses with a regex.
There was a problem hiding this comment.
The point is not to check / validate the email address. We want to make sure this looks somewhat like a valid string used for an email address and not that a comma has been forgotten in the \addauthor macro.
IMO authors should not simply provide firstname dot lastname, if they provide an e-mail address it should resemble a real one.
| \prg_new_conditional:Npnn \iacr_check_inst:n #1 { T, F, TF } | ||
| { | ||
| \cs_generate_variant:Nn \regex_match:nnTF {nV} | ||
| % An institute index should be a number, multiple institutes are separated by a comma: |
There was a problem hiding this comment.
Note that the numbers are supposed to start at 1 (not 0), but a later check will notice this when the paper is compiled. I don't think we need to check it here.
There was a problem hiding this comment.
Exactly, same point as above. This is just a basic sanity check not a comprehensive validation.
|
I will wait from merging until CiC Issue 1 has been published. |
No description provided.