Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests, bump python version to 3.11 #29

Merged
merged 13 commits into from
Dec 13, 2023
Merged

Fix tests, bump python version to 3.11 #29

merged 13 commits into from
Dec 13, 2023

Conversation

juanep97
Copy link
Collaborator

No description provided.

@juanep97 juanep97 requested a review from Bultako December 13, 2023 11:03
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 142 lines in your changes are missing coverage. Please review.

Comparison is base (063fbd1) 92.36% compared to head (c049e11) 78.12%.
Report is 13 commits behind head on main.

❗ Current head c049e11 differs from pull request most recent head da2dd2e. Consider uploading reports for the commit da2dd2e to get more accurate results

Files Patch % Lines
mutis/flares/bayblocks.py 0.00% 111 Missing ⚠️
mutis/flares/flare.py 0.00% 28 Missing ⚠️
mutis/flares/__init__.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #29       +/-   ##
===========================================
- Coverage   92.36%   78.12%   -14.25%     
===========================================
  Files           9       12        +3     
  Lines         786      928      +142     
===========================================
- Hits          726      725        -1     
- Misses         60      203      +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanep97
Copy link
Collaborator Author

Tests are failing on lines of code that do not exist?

@juanep97
Copy link
Collaborator Author

It seems that it is not checking out the right version / commit, it is checking out main.

@juanep97
Copy link
Collaborator Author

For some reason the actions/checkout was checking out the base branch instead of the pushed commit. Setting refin the CI fixes it:

      - uses: actions/checkout@v4
        with:
          fetch-depth: 0
          ref: ${{ github.event.pull_request.head.sha }}

I have also updated to python 3.11 and the action versions.

@juanep97
Copy link
Collaborator Author

The issue with the actions/checkout might be related to actions/checkout#881. Setting refmanually looks fine to me.

@juanep97 juanep97 merged commit 8e71d44 into main Dec 13, 2023
3 checks passed
@juanep97 juanep97 deleted the dev branch December 13, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant