fix: clarify ApiImpl which methods are required or not #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdnninja
requested changes
Nov 16, 2024
|
|
||
| def set_charge_limits( | ||
| self, token: Token, vehicle: Vehicle, ac: int, dc: int | ||
| ) -> str: | ||
| """Sets charge limits. Returns the tracking ID""" | ||
| pass | ||
| raise NotImplementedError("required") |
There was a problem hiding this comment.
Shouldn't this match set_charging_current? Same with the other items above.
Self-document better. Make update_geocoded_location() a staticmethod since it doesn't depend on self.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-document better.
Make update_geocoded_location() a staticmethod since it doesn't depend on self.