Efficient filter-rewriting for st.text(...).filter(str.isidentifier)
#3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
reviewed
Aug 31, 2023
hypothesis-python/src/hypothesis/strategies/_internal/strings.py
Outdated
Show resolved
Hide resolved
hypothesis-python/src/hypothesis/strategies/_internal/strings.py
Outdated
Show resolved
Hide resolved
Zac-HD
reviewed
Sep 5, 2023
hypothesis-python/src/hypothesis/strategies/_internal/strings.py
Outdated
Show resolved
Hide resolved
hypothesis-python/src/hypothesis/strategies/_internal/strings.py
Outdated
Show resolved
Hide resolved
Comment on lines
+355
to
+356
| # Should we deterministically check whether ascii or not or st.characters fine? | ||
| @pytest.mark.parametrize("al", [None, "cdef123", "cd12¥¦§©"]) |
There was a problem hiding this comment.
Fine to ignore the non-OneCharStringStrategy case (fyi sampled_from() is automatically converted in text()!); definitely good to test both ascii and non-ascii.
Zac-HD
changed the title
st.text(...).filter(str.isidentifier)
Zac-HD
force-pushed
the
text_filter_strat
branch
3 times, most recently
from
a2ca289 to
4d146f5
Compare
|
Thanks Reagan! This was surprisingly tricky to get working at a low level, but your logic and faster intersection calculation were really useful - and will have a big impact in Zac-HD/hypothesmith#32 very soon 😁 (comment instead of review because github is currently degraded!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3480
Adds more efficient strategy for
st.text(...).filter(str.isidentifier). When runningst.text().filter(str.isidentifier)on 100 iterations,