-
Notifications
You must be signed in to change notification settings - Fork 14
Transverse link labels & syntax flagging #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general issues/guidelines (to discuss):
- we need to decide to go with either "XXXOf" or "isXXXOf" and stick with one (go with "isXXXOf")
- properties that are not links don't get a reversed link label
- name and label should be the same (just changing camel case, and with space)
@@ -2,8 +2,9 @@ | |||
"https://openminds.ebrains.eu/vocab/IRI": { | |||
"description": "Stands for Internationalized Resource Identifier which is an internet protocol standard that builds on the URI protocol, extending the set of permitted characters to include Unicode/ISO 10646.", | |||
"label": "IRI", | |||
"labelForReverseLink": "Is IRI of", | |||
"labelForReverseLink": "Identifies", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We avoided so far using verbs in properties and I think we should stick to that (we can re-discuss though). A generic solution would be "isIdentifierOf".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think reverse links should not be more generic than the actual link (this could lead to conflicts). I would stick with "isIRIOf"
}, | ||
"https://openminds.ebrains.eu/vocab/about": { | ||
"description": null, | ||
"label": "About", | ||
"labelForReverseLink": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed I think. The reverse link could actually be the same as the normal link ("about").
@@ -71,15 +101,21 @@ | |||
"https://openminds.ebrains.eu/vocab/abstract": { | |||
"description": null, | |||
"label": "Abstract", | |||
"labelForReverseLink": "Abstract of", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consistency: stick to either "isXXXOf" or to "XXXOf"
"formating": { | ||
"formattedText": true, | ||
"multilineText": true | ||
} | ||
}, | ||
"https://openminds.ebrains.eu/vocab/addExistingTerminology": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this property needs to be changed. this includes the instruction which should be avoided
"schemas": [ | ||
"controlledTerms/v1/termSuggestion" | ||
] | ||
}, | ||
"https://openminds.ebrains.eu/vocab/additionalInformation": { | ||
"description": null, | ||
"label": "Additional information", | ||
"labelForReverseLink": "Are additional information for", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be "Is additional information for"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think this shouldn't be anything. there are no linked Types that means no reversed link either
}, | ||
"https://openminds.ebrains.eu/vocab/addExistingTerminology": { | ||
"description": "Reference to an existing terminology (distinct class to group related terms).", | ||
"label": "Add existing terminology", | ||
"labelForReverseLink": "Is add existing terminology of", | ||
"labelForReverseLink": "Suggested in", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Suggested (Terminology) for"
}, | ||
"https://openminds.ebrains.eu/vocab/additionalRemarks": { | ||
"description": "Mention of what deserves additional attention or notice.", | ||
"label": "Additional remarks", | ||
"labelForReverseLink": "Are additional remarks for", | ||
"name": "additionalRemarks", | ||
"nameForReverseLink": "areAdditionalRemarksFor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no link, so no reversed link needed
"linkedTypes": [ | ||
"https://openminds.ebrains.eu/controlledTerms/UBERONParcellation", | ||
"https://openminds.ebrains.eu/sands/CustomAnatomicalEntity", | ||
"https://openminds.ebrains.eu/sands/ParcellationEntity" | ||
], | ||
"name": "anatomicalLocation", | ||
"nameForReverseLink": "isLocationOf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not consistent with label
"linkedTypes": [], | ||
"name": "arguments", | ||
"nameForReverseLink": "areArgumentOf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inconsistent
No description provided.