Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBRAINS theme + Other improvements & Fixes #335

Merged

Conversation

appukuttan-shailesh
Copy link
Collaborator

@appukuttan-shailesh appukuttan-shailesh commented Aug 8, 2022

Changes the app theme to align with EBRAINS

Other changes

  • update navbar for model/test detail page to combine figures & results under a header 'validations'
  • fixed faulty results handling for model/test detail page vs multicompare workflow (see convertResultsFormat())
  • removes ThreeWaySwitch in place of generic SwitchMultiWay
  • contains GUI elements for adding curation and validation filters to config form (commented out at the moment; awaiting development of features)
  • fixes bug in edit test for data location
  • improves appearance of all tables (model-> results, test-> results, multi-result compare)

@appukuttan-shailesh appukuttan-shailesh changed the title Ebrains theme EBRAINS theme + Other improvements & Fixes Aug 8, 2022
@apdavison
Copy link
Member

apdavison commented Aug 11, 2022

is this ready to merge? or does it need some backend changes to be deployed first? (e.g. curated models)

@appukuttan-shailesh
Copy link
Collaborator Author

appukuttan-shailesh commented Aug 11, 2022

This is already functional. Components for upcoming features have been commented out.
I would like to make some more theme-related changes, and hope to do that tomorrow.
Shall update here once ready.

@appukuttan-shailesh
Copy link
Collaborator Author

@apdavison : this is now ready to be merged

@appukuttan-shailesh appukuttan-shailesh merged commit d00a6b7 into HumanBrainProject:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants