Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL and version of flake8 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update URL and version of flake8 #3

wants to merge 1 commit into from

Conversation

ylep
Copy link
Collaborator

@ylep ylep commented Nov 17, 2022

Flake8 has moved to GitHub and their GitLab repository is not accessible anymore, so the pre-commit configuration for flake8 tests need to be updated.

Unfortunately tests seem to break for other reasons under Python 3.8 and 3.10, and I have no time to investigate these failures.

@ylep ylep added the bug Something isn't working label Nov 17, 2022
@xgui3783
Copy link
Collaborator

xgui3783 commented Nov 18, 2022

for failed test in 3.8, seems related to: aws/aws-sam-cli#3661

edit: also see this SO post: https://stackoverflow.com/questions/72191560/importerror-cannot-import-name-soft-unicode-from-markupsafe

we should consider if pinning markupsafe is desirable.

@xgui3783
Copy link
Collaborator

for the failed test in 3.10, it's even more bizarre. Tests pass but tox returns 1.

perhaps similar to : travis-ci/travis-ci#9096 ?

@skoehnen
Copy link
Collaborator

for the failed test in 3.10, it's even more bizarre. Tests pass but tox returns 1.

perhaps similar to : travis-ci/travis-ci#9096 ?

It looks like the same error happens in 3.10 as well, just that tox continues on.

See line 31 and 30 of the log.

@skoehnen
Copy link
Collaborator

What I was able to gather so far is that the virtual environment, which tox creates, uses Jinja2 in version 2.11.3 and MarkupSafe in version 2.1.1, which is not a compatible combination.

So far I tried to tell tox to use a specific version in the virtual environment creation, but it does not seem to stick.

@skoehnen
Copy link
Collaborator

So it seems like updating Jinja2 causes a lot more dependency problems, for example it needs a specific version of Flask.

I will now try to downgrade MarkupSafe and see if this fixes it.

@skoehnen
Copy link
Collaborator

Yes, downgrading MarkupSafe works.
And for some reason I can add it "normally" as a dependency in tox, instead of having to use the Jinja2 work-arounds.

I will try to add a commit to this PR, not sure if I am allowed to do that in this Repo.

@skoehnen
Copy link
Collaborator

No, I can't push to branches in this repository.
@xgui3783 @ylep @dickscheid could one of you please invite me.

@xgui3783
Copy link
Collaborator

I don't have admin permission unfortunately.

@skoehnen
Copy link
Collaborator

I could fork the repository and start a PR from there, but avoiding that would be cleaner.
Maybe @dickscheid or @ylep can help.

@ylep
Copy link
Collaborator Author

ylep commented Mar 13, 2023

Hi @skoehnen , I realize that I was horribly late dealing with my Github notifications, sorry :-/ Apparently you do have write access to this repository now, you are welcome to upload your fix if you still have it available :-)

xgui3783 added a commit that referenced this pull request Nov 23, 2023
supercedes #3
@xgui3783 xgui3783 mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants