Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgraphqlparser: deprecate as it requires Python 2 #83290

Closed
wants to merge 1 commit into from
Closed

libgraphqlparser: deprecate as it requires Python 2 #83290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Formula/libgraphqlparser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ class Libgraphqlparser < Formula
sha256 cellar: :any, high_sierra: "64779ec3108d9eef789d279abfafa90437c6a76b2ed3973d45979cd1051dc170"
end

deprecate! date: "2020-04-20", because: "requires Python 2 to build"
Copy link
Member Author

@cho-m cho-m Aug 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some dates I was considering:

  • 2020-04-20 was final Python 2 (2.7.18) release date.
  • 2020-01-01 was official Python 2 EOL date.

Could also just use current date or 2021-04-20 as 1+ year after final release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just go with today, so that it's easier for us to figure out if enough time has passed to disable! it.


depends_on "cmake" => :build
depends_on :macos # Due to Python 2

Expand Down