libgcrypt: fix build on Apple Silicon #66728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
reviewed
Dec 11, 2020
Formula/libgcrypt.rb
Outdated
| # broke the validity of its code signature. Have to | ||
| # re-sign the binary so that it can be authorized to | ||
| # run on Apple Silicon. | ||
| system("codesign", "-s", "-", "#{buildpath}/tests/.libs/random") |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fxcoudert
previously approved these changes
Dec 11, 2020
BrettDong
force-pushed
the
libgcrypt-fix
branch
from
145e0dd to
e674fde
Compare
9 tasks
fxcoudert
reviewed
Dec 11, 2020
Co-authored-by: FX Coudert <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?libgcryptfails to build on Apple Silicon atmake checkstep. Log message reveals that the processrandom, one of the checks inmake check, was killed by the OS. System log indicates that the process is killed because of invalid signature:The reason is that after
makeand beforemake check, a workaround procedure in Formula modified the binaryrandomand broke its original code signature, so the executable was refused to run. The problem is solved by adding a step of creating an ad-hoc code signature.