Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KisMac2 (0.3.4) #24465

Merged
merged 1 commit into from
Sep 14, 2016
Merged

Add KisMac2 (0.3.4) #24465

merged 1 commit into from
Sep 14, 2016

Conversation

kai5263499
Copy link
Contributor

@kai5263499 kai5263499 commented Sep 14, 2016 •
edited
Loading

Checklist

  • The commit message includes the cask’s name and version.
  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} left no offenses.

Additionally, when adding a new cask:

  • Checked there are no open pull requests for the same cask.
  • Checked there are no closed issues where that cask was already refused.
  • When naming the cask, followed the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.

@kai5263499 kai5263499 mentioned this pull request Sep 14, 2016
Open
vitorgalvao
vitorgalvao reviewed Sep 14, 2016
View reviewed changes
Casks/kismac2.rb
@@ -0,0 +1,12 @@
cask 'kismac2' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the 2. The version reference mentions version numbers are to be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 2 is necessary since it's in the project name

Copy link
Member

@vitorgalvao vitorgalvao Sep 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s inconsistently the project’s name. And the former one appears to be dead and this one is the new official one.

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label Sep 14, 2016
@kai5263499
Copy link
Contributor Author

I've made the requested changes

@vitorgalvao
Copy link
Member

Thank you.

@vitorgalvao vitorgalvao merged commit 36259af into Homebrew:master Sep 14, 2016
@mikeyx2440
Copy link

Thank you I appreciate your hard work

jedahan pushed a commit to jedahan/homebrew-cask that referenced this pull request Sep 24, 2016
@kai5263499
Add KisMac2 (0.3.4) (Homebrew#24465)
133f791
@miccal miccal removed the awaiting user reply Issue needs response from a user. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kai5263499 @vitorgalvao @mikeyx2440 @miccal