Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate tap pinning (and remove odisabled) #5925

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Deprecate tap pinning (and remove odisabled) #5925

merged 2 commits into from
Apr 3, 2019

Conversation

MikeMcQuaid
Copy link
Member

Tap pinning is not used by Homebrew or the Homebrew maintainers so issues relating to pinned taps (#5418, #5796) don’t get fixed. Tap pinning does not work consistently or reliably and is conceptually confusing to encourage users to use fully-scoped user/tap/formula naming or avoid shadowing core tap formulae' names instead.

While we are handling deprecations: remove all odisabled.

This will not be merged until the next minor release is imminent.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@slhck
Copy link

slhck commented Mar 29, 2019

fully-scoped user/tap/formula naming or avoid shadowing core tap formulae' names.

To a novice user, that wording may be confusing. When the user calls tap-pin, it can be assumed that they explicitly want to override the default. Perhaps one could immediately print:

brew tap-pin foo/bar (where foo/bar is whatever the user wrote) is deprecated. If you want to install formulae from foo/bar, always use the full formula name (foo/bar/<formula>).

Also, the "is shadowed by" message that is printed when the user does something with a tap formula that shadows a core formula … maybe it could mention that this behavior is going away?

@MikeMcQuaid
Copy link
Member Author

@slhck Good points, I've updated some of the messaging.

Tap pinning is not used by Homebrew or the Homebrew maintainers so issues relating to pinned taps (#5418, #5796) don’t get fixed. Tap pinning does not work consistently or reliably and is conceptually confusing to encourage users to use fully-scoped user/tap/formula naming or avoid shadowing core tap formulae' names instead.
@MikeMcQuaid MikeMcQuaid merged commit 8d01cda into Homebrew:master Apr 3, 2019
@MikeMcQuaid MikeMcQuaid deleted the more-deprecations branch April 3, 2019 08:00
bazel-io pushed a commit to bazelbuild/bazel that referenced this pull request Apr 23, 2019
Tap pinning is deprecated (Homebrew/brew#5925) in favor of using the fully qualified name.

Closes #8027.

PiperOrigin-RevId: 244838884
@lock lock bot added the outdated PR was locked due to age label May 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants