rubocops/*: improve test descriptions #10334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2021-01-18 at 03:08:47 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
approved these changes
Jan 15, 2021
Rylan12
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
LGTM, thanks, @SeekingMeaning!
One minor non-blocking suggestion
| context "When auditing urls" do | ||
| it "with offenses" do | ||
| context "when auditing URLs" do | ||
| it "reports any offenses" do |
There was a problem hiding this comment.
Minor but maybe this should be:
Suggested change
| it "reports any offenses" do | |
| it "reports all offenses" do |
There was a problem hiding this comment.
I wasn't sure how to describe this as technically this doesn't report all offenses since there are the two others below this
There was a problem hiding this comment.
Yeah, I see what you mean. What you just pushed looks great to me (plus bonus clarity because formulae isn't that descriptive of what it is)
Rylan12
approved these changes
Jan 15, 2021
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Jan 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?Continuation of #10124
This PR improves some test descriptions so that the error messages are more coherent
Before:
RuboCop::Cop::FormulaAudit::ComponentsOrder no on_os_block does not fail when there is no on_os blockAfter:
RuboCop::Cop::FormulaAudit::ComponentsOrder when formula has no OS-specific blocks reports no offenses