Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac/hardware: clarify Rosetta 2 situation with a comment. #10161

Merged
merged 1 commit into from
Dec 28, 2020
Merged

os/mac/hardware: clarify Rosetta 2 situation with a comment. #10161

merged 1 commit into from
Dec 28, 2020

Conversation

MikeMcQuaid
Copy link
Member

Expand on #10153 to provide an in-code comment (in case someone goes to change this in future).

Expand on #10153 to provide an in-code comment (in case someone goes to
change this in future).
@BrewTestBot
Copy link
Member

Review period will end on 2020-12-29 at 09:10:18 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 28, 2020
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Dec 28, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 28, 2020

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 28, 2020
@MikeMcQuaid MikeMcQuaid merged commit fdb71a5 into Homebrew:master Dec 28, 2020
@MikeMcQuaid MikeMcQuaid deleted the rosetta-bottles-comment branch December 28, 2020 10:38
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 1, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants