Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sparkle strategy. #10125

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Fix Sparkle strategy. #10125

merged 1 commit into from
Dec 24, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Dec 24, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fix regression introduced in #10106.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-25 at 02:34:41 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 24, 2020
@reitermarkus reitermarkus added the critical Critical change which should be shipped as soon as possible. label Dec 24, 2020
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 24, 2020
@BrewTestBot
Copy link
Member

BrewTestBot commented Dec 24, 2020 •
edited
Loading

Review period ended.

@reitermarkus reitermarkus merged commit d535fe3 into Homebrew:master Dec 24, 2020
@reitermarkus reitermarkus deleted the sparkle branch December 24, 2020 03:11
@reitermarkus reitermarkus mentioned this pull request Dec 24, 2020
Closed
3 tasks
@samford
Copy link
Member

samford commented Dec 25, 2020

Sorry about that. I hadn't yet added examples of the new strategies (HeaderMatch and Sparkle) to my watchlist and I only tested that PR on homebrew/core, so that bug snuck through. I expanded my watchlist yesterday and I'm planning to regularly test PRs on both homebrew/core and homebrew/cask in the future (once we've finished reviewing and integrating the current batch of livecheck blocks in casks).

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 24, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reitermarkus @BrewTestBot @samford