Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test/support/github_formatter with rspec-github gem #10100

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Dec 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

  • This was a TODO in test/support/github_formatter.rb and the PR it referenced had been merged.
  • Will mark as not-draft when CI passes - Xcode is updating on my local machine and taking forever.

- This was a TODO in `test/support/github_formatter.rb` and the PR it
  referenced had been merged.
@issyl0 issyl0 requested a review from reitermarkus December 22, 2020 18:14
@BrewTestBot
Copy link
Member

Review period will end on 2020-12-23 at 18:14:40 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 22, 2020
@issyl0 issyl0 marked this pull request as ready for review December 22, 2020 19:28
@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 23, 2020
@issyl0 issyl0 merged commit e041468 into Homebrew:master Dec 23, 2020
@issyl0 issyl0 deleted the use-rspec-github-gem branch December 23, 2020 19:02
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 23, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants