More flexible WildCat.Paths instances #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows wildcat structures to be augmented with paths in the higher cells. Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: 131ed041-c712-4bed-93c1-f873e0569871 -->
jdchristensen
approved these changes
Jun 12, 2024
Co-authored-by: Dan Christensen <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
theories/WildCat/Paths.v
Outdated
Comment on lines
39
to
40
| intros f h p. | ||
| by destruct p. |
There was a problem hiding this comment.
Suggested change
| intros f h p. | |
| by destruct p. | |
| exact (@ap _ _ (cat_postcomp a g)). |
(exact (@ap _ _ _).also works, but the above is more clear.) So this could also be a one-liner. (Also applies to next result.)
There was a problem hiding this comment.
I hope it's ok that I just pushed this, along with removing a bunch of beta expansions. I'm just try to keep terms syntactically small in some of this basic material. Feel free to revert if you don't like it.
There was a problem hiding this comment.
That all looks fine to me.
|
Ok, this LGTM! @ThomatoTomato this should help with the matrix category. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows wildcat structures to be augmented with paths in the higher cells.
cc @ThomatoTomato