-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Z-module structure on abelian groups #1992
Draft
ThomatoTomato
wants to merge
3
commits into
HoTT:master
Choose a base branch
from
ThomatoTomato:AbGrpIsZMod
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
Require Import Classes.interfaces.canonical_names. | ||
Require Import Algebra.AbGroups. | ||
Require Import Algebra.Rings.CRing. | ||
Require Import Algebra.Rings.Module. | ||
Require Import Spaces.BinInt Spaces.Pos. | ||
Require Import WildCat.Core. | ||
|
||
|
@@ -254,3 +255,38 @@ Proof. | |
apply ap. | ||
exact IHp. | ||
Defined. | ||
|
||
Section Lm_carrierIsEquiv. | ||
|
||
(** lm_carrier is a 1-functor (LeftModule R) -> AbGroup. *) | ||
Global Instance lm_carrieris0fun {R} : Is0Functor (lm_carrier R). | ||
Proof. | ||
snrapply Build_Is0Functor. | ||
intros a b f. | ||
ThomatoTomato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
destruct f. | ||
exact lm_homo_map. | ||
ThomatoTomato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Defined. | ||
|
||
Global Instance lm_carrieris1fun {R} : Is1Functor (lm_carrier R). | ||
Proof. | ||
snrapply Build_Is1Functor. | ||
- intros a b f g e. assumption. | ||
ThomatoTomato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- reflexivity. | ||
- reflexivity. | ||
Defined. | ||
(* I think the above should be moved to Module.v, as it is not specifically a property of the integers. *) | ||
ThomatoTomato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
(** Every abelian group admits a canonical left Z-module structure. *) | ||
Definition can_Z : AbGroup -> (LeftModule cring_Z). | ||
Proof. | ||
intros A. snrapply Build_LeftModule. | ||
- assumption. | ||
ThomatoTomato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- snrapply (Build_IsLeftModule _). | ||
ThomatoTomato marked this conversation as resolved.
Show resolved
Hide resolved
|
||
+ intros n a. exact (ab_mul n a). | ||
+ unfold LeftHeteroDistribute. intros n. exact preserves_sg_op. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is |
||
+ unfold RightHeteroDistribute. intros m n a. destruct m, n; simpl. | ||
-- | ||
(* This might be the wrong way to do this. On this path I need to prove that grp_pow respects addition of natural numbers. *) | ||
Admitted. | ||
|
||
End Lm_carrierIsEquiv. | ||
ThomatoTomato marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment style as I mentioned in the other PR. I'll let you check all comments.