more lemmas about matrix transpose #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: 5747319b-9b2e-406a-a46c-2faf417e06fd -->
Alizter
force-pushed
the
ps/rr/more_lemmas_about_matrix_transpose
branch
from
398b1ea to
5255072
Compare
Comment on lines
+302
to
+303
| Definition matrix_transpose_identity {R : Ring} {n} | ||
| : matrix_transpose (identity_matrix R n) = identity_matrix R n. |
There was a problem hiding this comment.
This is true more generally for diagonal matrices. Maybe the identity matrix should be defined as a diagonal matrix? Or if that makes other things too complicated, then there should be a lemma that the identity matrix is equal to the diagonal matrix for the constant vector of ones, and then this would follow from the corresponding factor for diagonal matrices.
There was a problem hiding this comment.
I did this initially, but it was annoying to have 1 * kronecker_delta around. Later in the PR about diagonal matrices we state the property of being a diagonal matrix and prove the general version too.
Co-authored-by: Dan Christensen <[email protected]>
jdchristensen
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prove that: