coproduct-product inclusion map #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: c9607964-281d-4e0a-ae36-ecc56167dbd6 -->
jdchristensen
approved these changes
Apr 16, 2024
|
Yes, I can add those here. |
Signed-off-by: Ali Caglayan <[email protected]>
|
I've shown that pType has all products and redefined the wedge inclusion. However I couldn't get the typeclasses to be found. AFAICT the instances are declared but Coq just cannot find them. My best guess is that unfolding is blocking Coq from finding things, since |
Signed-off-by: Ali Caglayan <[email protected]>
|
I worked out what was causing the issue with the instances: |
Signed-off-by: Ali Caglayan <[email protected]>
|
Instead of locally disabling minimization to Set, I added a universe variable. And I made a couple of other minor changes. If you agree with my changes, feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalises the wedge inclusion to other categories. I don't see anyway of removing the decidable paths requirement. In general I would assume this is equivalent to AC.