CayleyDickson: some cleanups, remove funext #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdchristensen
approved these changes
Jan 8, 2024
|
Nice! |
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
ps/branch/cayleydickson__some_cleanups__remove_funext
branch
from
b093650 to
5efe1b9
Compare
|
@jdchristensen I've used lhs a few times, but it didn't interact well in cd_op_right_identity due to the extreme blow up of term size causing coq to lag. The reason is because we are using rewrite in the operation. At some point we should try to do this cleanly as the rewrite terms are really bad for performance when unfolded. |
Alizter
deleted the
ps/branch/cayleydickson__some_cleanups__remove_funext
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've being playing around with the proofs in Cayley-Dickson and here are some speedups and cleanups.
Notably funext is removed by using the old intro-revert trick when eliminating multiple hyps of a HIT.