-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error details & Generator improvements #22
Conversation
Syntax highlighting on templates if helpful. 😊
Nice automation! |
e07773d
to
7dc942c
Compare
This resulted in a memory usage reduction from ~240Mb to ~50Mb and a time reduction from 2.8s to 136ms when running `python -c 'import pyconnectwise'`.
I pushed a few more commits today. The most notable one is lazy-loading endpoints. Before the lazy-loading endpoints change: After the change: |
This PR is fantastic - I love the additions to lazy loading the imports. I still have more testing I'd like to do with it (with generating Automate files especially) but other than that I can't see any downsides to this. I expect to merge soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged - thanks again for your incredible contribution! |
So I started with some more improvements to providing error details in exceptions, then I got carried away and did a bunch of work on the generator.
Changes include:
I think that's everything worth mentioning. Now I've got to figure out/remember what started me on this journey in the first place. 😁