Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.4.5 #10

Merged
merged 11 commits into from
Aug 22, 2023
Merged

Version 0.4.5 #10

merged 11 commits into from
Aug 22, 2023

Conversation

Yoshify
Copy link
Contributor

@Yoshify Yoshify commented Aug 22, 2023 •
edited
Loading

This version fixes numerous issues:

  • Namespace collisions with generated models no longer occur
  • Importing models for adding your own annotations is significantly easier - all models are now contained within their model modules init. So, for example, one can now do: from pyconnectwise.models.manage import Company
  • Models now use Literal types for enum fields instead of Enums - this feels much nicer to work with in my opinion, but open to feedback.
  • Tidied and removed redundant or legacy code.
  • Added support for void methods in generated endpoints.

Yoshify added 11 commits August 22, 2023 14:37
@Yoshify
🔧 update pycharm config
897bab2
@Yoshify
🔧 update .gitignore
74c2ff3
@Yoshify
🔨 added shell script for generating models with preferred defaults
5045b45
@Yoshify
🔨 updated endpoint generator script for new model paths
58a7c61
@Yoshify
🔨 added script for post-processing OpenAPI specs and making the schem…
47f4693 
…a/ref names nicer
@Yoshify
🔥 removed unnecessary code
4cd8efb
@Yoshify
🔥 removed redundant id() function from connectwise_endpoint base class
1658f1c
@Yoshify
✨💥 moved all generated models to __init__.py
1bced24 
This allows for easier importing when coding, eg:
```
from pyconnectwise.models.manage import Company
```

Also, to solve namespace clashes, all models names have been updated (which is a breaking change for people using old naming, if any). Model names now use parts of their namespace in the name.

Enum's have been converted to Literals.
@Yoshify
🔨 updated codegen templates
5d934a7
@Yoshify
⚡️💥 regenned endpoints
e967f50 
Endpoints now use new model names
Added support for void methods (like most DELETE requests) as they have no return type.
@Yoshify
⬆️ bump requirements
6961425
@Yoshify Yoshify self-assigned this Aug 22, 2023
@Yoshify Yoshify merged commit a95135f into main Aug 22, 2023
@Yoshify Yoshify deleted the 0.4.5 branch August 22, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Yoshify Yoshify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Yoshify