feat(spaces): add force arg for moveWindowToSpace #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuuva
force-pushed
the
force-move-window-to-space
branch
from
69fcddc to
110aa0e
Compare
cmsj
requested changes
Nov 2, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Floating windows can be drawn over full screen windows so there should be a way to move them into full screen spaces as well.
okuuva
force-pushed
the
force-move-window-to-space
branch
from
110aa0e to
f71e586
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floating windows can be drawn over full screen windows so there should be a way to move them into full screen spaces as well.
Tested that this works with a floating window (kitty to be precise). Also tested moving a fullscreen window to a fullscreen (and normal) space and confirmed that it does not work. It does try to do it and return
truebut the source space just goes black and the window doesn't appear at the destination space (which is expected but wanted to check what happens). My extremely limited (read: none) knowledge in Obj C can get only so far, if we want to prevent even trying to move fullscreen windows even withforce = trueI need some help with that. I think it would be better to check if the window is in fullscreen rather than checking the source space type but don't know how to do that from withinspacesextension or if it's even possible.