Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added react ^19 and ^19.0.0-rc as peer dep #5250

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

aminabromand
Copy link
Contributor

Added react ^19 and ^19.0.0-rc as peer dependency. Some projects like Next.js already utilize react 19 release candidate, so that installing react-datepicker can only be done with --legacy-peer-deps. I have tested the react-datepicker with Next.js and react 19 release candidate and it works. So I have added react ^19 and ^19.0.0-rc as peer dep


name: Pull Request
about: Create a pull request to improve this repository
title: ""
labels: ""
assignees: ""

Description

Linked issue: #()

Problem
Using react-datepicker with Next.js only works with --legacy-peer-deps

Changes
Added react ^19 and ^19.0.0-rc as peer dep

Screenshots

To reviewers

Contribution checklist

  • [X ] I have followed the contributing guidelines.
  • [X ] I have added sufficient test coverage for my changes. - no explicit test added, but all tests pass.
  • [ X] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Added react ^19 and ^19.0.0-rc as peer dependency.
Some projects like Next.js already utilize react 19 release candidate, so that installing react-datepicker can only be done with `--legacy-peer-deps`.
I have tested the `react-datepicker` with Next.js and react 19 release candidate and it works.
So I have added react ^19 and ^19.0.0-rc as peer dep
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@aminabromand you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 2
- 2

100% JSON

Generated lines of change

+ 2
- 2

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No security issues found. No merge blocking issues found. Thanks for the PR.

Image of Frank T Frank T


Reviewed with ❤️ by PullRequest

@martijnrusschen
Copy link
Member

Please check CI output.

@aminabromand
Copy link
Contributor Author

Please check CI output.

I have made the needed changes in yarn.lock as per CI output.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (2452507) to head (a4bfe9e).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5250      +/-   ##
==========================================
+ Coverage   96.89%   96.92%   +0.02%     
==========================================
  Files          29       29              
  Lines        3381     3377       -4     
  Branches     1401     1417      +16     
==========================================
- Hits         3276     3273       -3     
+ Misses        105      102       -3     
- Partials        0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijnrusschen martijnrusschen merged commit 4ce96a0 into Hacker0x01:main Dec 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants