Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused prop-types dependency #5248

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

jimender2
Copy link
Contributor


name: Remove unused prop-types dependency
about: Found an unused dependency and removed it
title: ""
labels: ""
assignees: ""

Description

Was looking through dependencies and noticed that prop-types was in the dependency list. This library is not actually imported in the core library and is instead only used inside the demo app. The Readme also mentions that prop-types is not bundled and should be installed if needed.
Linked issue: #(issue number)

Problem

Changes
Ran yarn remove prop-types

Screenshots

To reviewers

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@jimender2 you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 22
- 6

100% JSON

Generated lines of change

+ 0
- 1

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough! I certainly have no issues with removing an unused dependency.

Image of Jacob Jacob


Reviewed with ❤️ by PullRequest

@martijnrusschen martijnrusschen merged commit 9baba30 into Hacker0x01:main Dec 1, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants