fix(types): PropsWithChildren type argument issue
#5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@mertJF you can click here to see the review status or cancel the code review job.
|
looks like the linter is failing, can you review and fix? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5223 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 29 29
Lines 3381 3381
Branches 1401 1414 +13
=======================================
Hits 3276 3276
Misses 105 105 ☔ View full report in Codecov by Sentry. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current CalendarProps type definition is incorrect, leading to type errors when using the component. This issue arises because
React.PropsWithChildrenis a generic type that requires a type argument to specify the component's props.Changes
This PR fixes the type definition by correctly combining
React.PropsWithChildrenwithCalendarProps. This ensures proper type checking and prevents potential runtime errors.Screenshots
Contribution checklist