fix: #3840 Rollup config #4622
fix: #3840 Rollup config #4622
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4622 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 28 28
Lines 2601 2601
Branches 1095 1095
=======================================
Hits 2522 2522
Misses 79 79 ☔ View full report in Codecov by Sentry. |
| }, | ||
| { | ||
| file: "dist/react-datepicker.js", | ||
| file: pkg.browser.replace(".min.js", ".js"), |
There was a problem hiding this comment.
The resulting string will be the same
There was a problem hiding this comment.
I meant that the resulting string would be the same as the string before the modification.
|
before this PR result https://github.com/Hacker0x01/react-datepicker/actions/runs/8352735857/job/22863286969?pr=4622 |
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@yuki0410-dev you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Looks good. Definitely recommend having source maps and un-minimized code for open-source JS projects.
Reviewed with ❤️ by PullRequest
Description
Linked issue: close #3840
Problem
See issue #3840
Changes
Screenshots
To reviewers
In the issue, it was mentioned that it would be useful to have uncompressed code, but for debug purposes, we thought it would be better to add a source map as well, so we set it up.
In the case of cjs,ems, basically, compression is done in the production build of the module bundler on the user's side, so we do not think that compression on the library side is mandatory. (I assume the source map will also be removed at this time.)
（I am a little confused as to whether to compress just min.js or everything.）
I would be glad to hear your comments on the above two points.
Contribution checklist