Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-label to calendar container for accessibility #4568

Merged

Conversation

barettjfed
Copy link
Contributor

Fixes #4555

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@barettjfed you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 2
- 1

67% JavaScript
33% JavaScript (tests)

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (93dbc55) to head (a480f73).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4568   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          28       28           
  Lines        2561     2561           
  Branches     1074     1074           
=======================================
  Hits         2481     2481           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always great to see proper handling of accessibility, and nice attention to detail including a test even for such a small change. Looks good to me!

Image of Ryan Lester <@buu700> Ryan Lester <@buu700>


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aria-label addition looks good to me, and should help with a11y.

Image of Joey G Joey G


Reviewed with ❤️ by PullRequest

@martijnrusschen martijnrusschen merged commit f41bd1b into Hacker0x01:main Mar 7, 2024
6 checks passed
@meriouma
Copy link

Is there a plan for adding i18n support for a11y properties?

@barettjfed
Copy link
Contributor Author

@meriouma I don't have any plans to support that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The calendar dialog is missing an accessibility property
3 participants