-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aria-label to calendar container for accessibility #4568
Add aria-label to calendar container for accessibility #4568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network.
@barettjfed you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 2
- 1
67% JavaScript
33% JavaScript (tests)
Type of change
Minor Update - These changes appear to be a minor update to existing functionality and features.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4568 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 28 28
Lines 2561 2561
Branches 1074 1074
=======================================
Hits 2481 2481
Misses 80 80 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always great to see proper handling of accessibility, and nice attention to detail including a test even for such a small change. Looks good to me!
Ryan Lester <@buu700>
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This aria-label
addition looks good to me, and should help with a11y.
Reviewed with ❤️ by PullRequest
Is there a plan for adding i18n support for a11y properties? |
@meriouma I don't have any plans to support that. |
Fixes #4555