-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerRef div shouldnt affect styling #4384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network.
@joaopaulo-capy you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 1
- 1
100% JavaScript
Type of change
Minor Update - These changes appear to be a minor update to existing functionality and features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4384 +/- ##
=======================================
Coverage 95.24% 95.24%
=======================================
Files 28 28
Lines 2479 2479
Branches 1020 1020
=======================================
Hits 2361 2361
Misses 118 118 ☔ View full report in Codecov by Sentry. |
@joaopaulo-capy -- This definitely had unfortunate negative side effects on inline calendars that I don't know how to fix. Before: After (because of |
Im sure this can be fixed easily. What kind of container is your inline calendar? Does your calendar have any styling? and is the expected behaviour your first print? Here are some experiments: My datepicker from the original post is also inline and just works However if i set a width to the container (in this example 100% width), your bug is reproduced This is kind of expected considering the month container is not responsive Here is month container with 100% width (still not the best solution because the day grid is not responsive and it would be hard to make it responsive, considering we would need to calculate the font-size responsively) Does wrapping your calendar arround a container (without any width style) fix your problem? |
Yes, wrapping in a |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^4.20.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/4.23.0/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-datepicker/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-datepicker/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-datepicker/4.23.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-datepicker/4.23.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v5.1.0`](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) ### [`v5.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.0.0): 5.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.25.0...v5.0.0) #### Breaking changes - Migrate from Popper.js to Floating-UI by [@​G07cha](https://togithub.com/G07cha) in [https://github.com/Hacker0x01/react-datepicker/pull/4393](https://togithub.com/Hacker0x01/react-datepicker/pull/4393) #### What's Changed - 🐛 FIX: readability-isMonthinRange by [@​mary139](https://togithub.com/mary139) in [https://github.com/Hacker0x01/react-datepicker/pull/4421](https://togithub.com/Hacker0x01/react-datepicker/pull/4421) - Fix [#​4431](https://togithub.com/Hacker0x01/react-datepicker/issues/4431): Update the excludedDate to match the year to check of the isYearDisabled by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4432](https://togithub.com/Hacker0x01/react-datepicker/pull/4432) - Fix [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): Update home key and end key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4430](https://togithub.com/Hacker0x01/react-datepicker/pull/4430) - Document [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): 📝 Update the behavior of Home Key and End Key in the README file by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4438](https://togithub.com/Hacker0x01/react-datepicker/pull/4438) - Fix [#​4076](https://togithub.com/Hacker0x01/react-datepicker/issues/4076): Trigger onCalendarClose event and onChange even when the same date is selected as the start and the end date in a date range by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4394](https://togithub.com/Hacker0x01/react-datepicker/pull/4394) - Excluded dates message by [@​dvelazquez1282](https://togithub.com/dvelazquez1282) in [https://github.com/Hacker0x01/react-datepicker/pull/4437](https://togithub.com/Hacker0x01/react-datepicker/pull/4437) - Fix [#​4456](https://togithub.com/Hacker0x01/react-datepicker/issues/4456): Add shift+pageUp key and shift+pageDown key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4457](https://togithub.com/Hacker0x01/react-datepicker/pull/4457) - Fix options passed to date-fns/format by [@​emilecantin](https://togithub.com/emilecantin) in [https://github.com/Hacker0x01/react-datepicker/pull/4469](https://togithub.com/Hacker0x01/react-datepicker/pull/4469) #### New Contributors - [@​mary139](https://togithub.com/mary139) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4421](https://togithub.com/Hacker0x01/react-datepicker/pull/4421) - [@​G07cha](https://togithub.com/G07cha) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4393](https://togithub.com/Hacker0x01/react-datepicker/pull/4393) - [@​dvelazquez1282](https://togithub.com/dvelazquez1282) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4437](https://togithub.com/Hacker0x01/react-datepicker/pull/4437) - [@​emilecantin](https://togithub.com/emilecantin) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4469](https://togithub.com/Hacker0x01/react-datepicker/pull/4469) **Full Changelog**: Hacker0x01/react-datepicker@v4.25.0...v5.0.0 ### [`v4.25.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.25.0): 4.25.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.24.0...v4.25.0) #### What's Changed - feature: Add day parameter to renderMonthContent function by [@​omarhoumz](https://togithub.com/omarhoumz) in [https://github.com/Hacker0x01/react-datepicker/pull/4405](https://togithub.com/Hacker0x01/react-datepicker/pull/4405) - Update 'Local Development' instruction of README.md by [@​raceStarter](https://togithub.com/raceStarter) in [https://github.com/Hacker0x01/react-datepicker/pull/4391](https://togithub.com/Hacker0x01/react-datepicker/pull/4391) - Feature [#​4091](https://togithub.com/Hacker0x01/react-datepicker/issues/4091) - Make the Calendar Icon clickable by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4417](https://togithub.com/Hacker0x01/react-datepicker/pull/4417) #### New Contributors - [@​omarhoumz](https://togithub.com/omarhoumz) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4405](https://togithub.com/Hacker0x01/react-datepicker/pull/4405) - [@​raceStarter](https://togithub.com/raceStarter) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4391](https://togithub.com/Hacker0x01/react-datepicker/pull/4391) **Full Changelog**: Hacker0x01/react-datepicker@v4.24.0...v4.25.0 ### [`v4.24.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.24.0): 4.24.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.23.0...v4.24.0) #### What's Changed - containerRef div shouldnt affect styling by [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) in [https://github.com/Hacker0x01/react-datepicker/pull/4384](https://togithub.com/Hacker0x01/react-datepicker/pull/4384) - Fix: reflect the `holidays` prop change by [@​shimech](https://togithub.com/shimech) in [https://github.com/Hacker0x01/react-datepicker/pull/4373](https://togithub.com/Hacker0x01/react-datepicker/pull/4373) - Disable clear button when the component is disabled by [@​Rafatcb](https://togithub.com/Rafatcb) in [https://github.com/Hacker0x01/react-datepicker/pull/4392](https://togithub.com/Hacker0x01/react-datepicker/pull/4392) #### New Contributors - [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4384](https://togithub.com/Hacker0x01/react-datepicker/pull/4384) - [@​shimech](https://togithub.com/shimech) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4373](https://togithub.com/Hacker0x01/react-datepicker/pull/4373) - [@​Rafatcb](https://togithub.com/Rafatcb) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4392](https://togithub.com/Hacker0x01/react-datepicker/pull/4392) **Full Changelog**: Hacker0x01/react-datepicker@v4.23.0...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^4.20.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/4.23.0/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-datepicker/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-datepicker/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-datepicker/4.23.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-datepicker/4.23.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v5.1.0`](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) ### [`v5.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.0.0): 5.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.25.0...v5.0.0) #### Breaking changes - Migrate from Popper.js to Floating-UI by [@​G07cha](https://togithub.com/G07cha) in [https://github.com/Hacker0x01/react-datepicker/pull/4393](https://togithub.com/Hacker0x01/react-datepicker/pull/4393) #### What's Changed - 🐛 FIX: readability-isMonthinRange by [@​mary139](https://togithub.com/mary139) in [https://github.com/Hacker0x01/react-datepicker/pull/4421](https://togithub.com/Hacker0x01/react-datepicker/pull/4421) - Fix [#​4431](https://togithub.com/Hacker0x01/react-datepicker/issues/4431): Update the excludedDate to match the year to check of the isYearDisabled by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4432](https://togithub.com/Hacker0x01/react-datepicker/pull/4432) - Fix [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): Update home key and end key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4430](https://togithub.com/Hacker0x01/react-datepicker/pull/4430) - Document [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): 📝 Update the behavior of Home Key and End Key in the README file by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4438](https://togithub.com/Hacker0x01/react-datepicker/pull/4438) - Fix [#​4076](https://togithub.com/Hacker0x01/react-datepicker/issues/4076): Trigger onCalendarClose event and onChange even when the same date is selected as the start and the end date in a date range by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4394](https://togithub.com/Hacker0x01/react-datepicker/pull/4394) - Excluded dates message by [@​dvelazquez1282](https://togithub.com/dvelazquez1282) in [https://github.com/Hacker0x01/react-datepicker/pull/4437](https://togithub.com/Hacker0x01/react-datepicker/pull/4437) - Fix [#​4456](https://togithub.com/Hacker0x01/react-datepicker/issues/4456): Add shift+pageUp key and shift+pageDown key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4457](https://togithub.com/Hacker0x01/react-datepicker/pull/4457) - Fix options passed to date-fns/format by [@​emilecantin](https://togithub.com/emilecantin) in [https://github.com/Hacker0x01/react-datepicker/pull/4469](https://togithub.com/Hacker0x01/react-datepicker/pull/4469) #### New Contributors - [@​mary139](https://togithub.com/mary139) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4421](https://togithub.com/Hacker0x01/react-datepicker/pull/4421) - [@​G07cha](https://togithub.com/G07cha) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4393](https://togithub.com/Hacker0x01/react-datepicker/pull/4393) - [@​dvelazquez1282](https://togithub.com/dvelazquez1282) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4437](https://togithub.com/Hacker0x01/react-datepicker/pull/4437) - [@​emilecantin](https://togithub.com/emilecantin) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4469](https://togithub.com/Hacker0x01/react-datepicker/pull/4469) **Full Changelog**: Hacker0x01/react-datepicker@v4.25.0...v5.0.0 ### [`v4.25.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.25.0): 4.25.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.24.0...v4.25.0) #### What's Changed - feature: Add day parameter to renderMonthContent function by [@​omarhoumz](https://togithub.com/omarhoumz) in [https://github.com/Hacker0x01/react-datepicker/pull/4405](https://togithub.com/Hacker0x01/react-datepicker/pull/4405) - Update 'Local Development' instruction of README.md by [@​raceStarter](https://togithub.com/raceStarter) in [https://github.com/Hacker0x01/react-datepicker/pull/4391](https://togithub.com/Hacker0x01/react-datepicker/pull/4391) - Feature [#​4091](https://togithub.com/Hacker0x01/react-datepicker/issues/4091) - Make the Calendar Icon clickable by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4417](https://togithub.com/Hacker0x01/react-datepicker/pull/4417) #### New Contributors - [@​omarhoumz](https://togithub.com/omarhoumz) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4405](https://togithub.com/Hacker0x01/react-datepicker/pull/4405) - [@​raceStarter](https://togithub.com/raceStarter) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4391](https://togithub.com/Hacker0x01/react-datepicker/pull/4391) **Full Changelog**: Hacker0x01/react-datepicker@v4.24.0...v4.25.0 ### [`v4.24.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.24.0): 4.24.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.23.0...v4.24.0) #### What's Changed - containerRef div shouldnt affect styling by [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) in [https://github.com/Hacker0x01/react-datepicker/pull/4384](https://togithub.com/Hacker0x01/react-datepicker/pull/4384) - Fix: reflect the `holidays` prop change by [@​shimech](https://togithub.com/shimech) in [https://github.com/Hacker0x01/react-datepicker/pull/4373](https://togithub.com/Hacker0x01/react-datepicker/pull/4373) - Disable clear button when the component is disabled by [@​Rafatcb](https://togithub.com/Rafatcb) in [https://github.com/Hacker0x01/react-datepicker/pull/4392](https://togithub.com/Hacker0x01/react-datepicker/pull/4392) #### New Contributors - [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4384](https://togithub.com/Hacker0x01/react-datepicker/pull/4384) - [@​shimech](https://togithub.com/shimech) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4373](https://togithub.com/Hacker0x01/react-datepicker/pull/4373) - [@​Rafatcb](https://togithub.com/Rafatcb) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4392](https://togithub.com/Hacker0x01/react-datepicker/pull/4392) **Full Changelog**: Hacker0x01/react-datepicker@v4.23.0...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^4.20.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/4.23.0/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-datepicker/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-datepicker/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-datepicker/4.23.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-datepicker/4.23.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v5.1.0`](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) ### [`v5.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.0.0): 5.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.25.0...v5.0.0) #### Breaking changes - Migrate from Popper.js to Floating-UI by [@​G07cha](https://togithub.com/G07cha) in [https://github.com/Hacker0x01/react-datepicker/pull/4393](https://togithub.com/Hacker0x01/react-datepicker/pull/4393) #### What's Changed - 🐛 FIX: readability-isMonthinRange by [@​mary139](https://togithub.com/mary139) in [https://github.com/Hacker0x01/react-datepicker/pull/4421](https://togithub.com/Hacker0x01/react-datepicker/pull/4421) - Fix [#​4431](https://togithub.com/Hacker0x01/react-datepicker/issues/4431): Update the excludedDate to match the year to check of the isYearDisabled by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4432](https://togithub.com/Hacker0x01/react-datepicker/pull/4432) - Fix [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): Update home key and end key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4430](https://togithub.com/Hacker0x01/react-datepicker/pull/4430) - Document [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): 📝 Update the behavior of Home Key and End Key in the README file by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4438](https://togithub.com/Hacker0x01/react-datepicker/pull/4438) - Fix [#​4076](https://togithub.com/Hacker0x01/react-datepicker/issues/4076): Trigger onCalendarClose event and onChange even when the same date is selected as the start and the end date in a date range by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4394](https://togithub.com/Hacker0x01/react-datepicker/pull/4394) - Excluded dates message by [@​dvelazquez1282](https://togithub.com/dvelazquez1282) in [https://github.com/Hacker0x01/react-datepicker/pull/4437](https://togithub.com/Hacker0x01/react-datepicker/pull/4437) - Fix [#​4456](https://togithub.com/Hacker0x01/react-datepicker/issues/4456): Add shift+pageUp key and shift+pageDown key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4457](https://togithub.com/Hacker0x01/react-datepicker/pull/4457) - Fix options passed to date-fns/format by [@​emilecantin](https://togithub.com/emilecantin) in [https://github.com/Hacker0x01/react-datepicker/pull/4469](https://togithub.com/Hacker0x01/react-datepicker/pull/4469) #### New Contributors - [@​mary139](https://togithub.com/mary139) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4421](https://togithub.com/Hacker0x01/react-datepicker/pull/4421) - [@​G07cha](https://togithub.com/G07cha) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4393](https://togithub.com/Hacker0x01/react-datepicker/pull/4393) - [@​dvelazquez1282](https://togithub.com/dvelazquez1282) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4437](https://togithub.com/Hacker0x01/react-datepicker/pull/4437) - [@​emilecantin](https://togithub.com/emilecantin) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4469](https://togithub.com/Hacker0x01/react-datepicker/pull/4469) **Full Changelog**: Hacker0x01/react-datepicker@v4.25.0...v5.0.0 ### [`v4.25.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.25.0): 4.25.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.24.0...v4.25.0) #### What's Changed - feature: Add day parameter to renderMonthContent function by [@​omarhoumz](https://togithub.com/omarhoumz) in [https://github.com/Hacker0x01/react-datepicker/pull/4405](https://togithub.com/Hacker0x01/react-datepicker/pull/4405) - Update 'Local Development' instruction of README.md by [@​raceStarter](https://togithub.com/raceStarter) in [https://github.com/Hacker0x01/react-datepicker/pull/4391](https://togithub.com/Hacker0x01/react-datepicker/pull/4391) - Feature [#​4091](https://togithub.com/Hacker0x01/react-datepicker/issues/4091) - Make the Calendar Icon clickable by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4417](https://togithub.com/Hacker0x01/react-datepicker/pull/4417) #### New Contributors - [@​omarhoumz](https://togithub.com/omarhoumz) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4405](https://togithub.com/Hacker0x01/react-datepicker/pull/4405) - [@​raceStarter](https://togithub.com/raceStarter) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4391](https://togithub.com/Hacker0x01/react-datepicker/pull/4391) **Full Changelog**: Hacker0x01/react-datepicker@v4.24.0...v4.25.0 ### [`v4.24.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.24.0): 4.24.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.23.0...v4.24.0) #### What's Changed - containerRef div shouldnt affect styling by [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) in [https://github.com/Hacker0x01/react-datepicker/pull/4384](https://togithub.com/Hacker0x01/react-datepicker/pull/4384) - Fix: reflect the `holidays` prop change by [@​shimech](https://togithub.com/shimech) in [https://github.com/Hacker0x01/react-datepicker/pull/4373](https://togithub.com/Hacker0x01/react-datepicker/pull/4373) - Disable clear button when the component is disabled by [@​Rafatcb](https://togithub.com/Rafatcb) in [https://github.com/Hacker0x01/react-datepicker/pull/4392](https://togithub.com/Hacker0x01/react-datepicker/pull/4392) #### New Contributors - [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4384](https://togithub.com/Hacker0x01/react-datepicker/pull/4384) - [@​shimech](https://togithub.com/shimech) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4373](https://togithub.com/Hacker0x01/react-datepicker/pull/4373) - [@​Rafatcb](https://togithub.com/Rafatcb) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4392](https://togithub.com/Hacker0x01/react-datepicker/pull/4392) **Full Changelog**: Hacker0x01/react-datepicker@v4.23.0...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^4.20.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/4.23.0/5.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-datepicker/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-datepicker/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-datepicker/4.23.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-datepicker/4.23.0/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v5.1.0`](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.0.0...v5.1.0) ### [`v5.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v5.0.0): 5.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.25.0...v5.0.0) #### Breaking changes - Migrate from Popper.js to Floating-UI by [@​G07cha](https://togithub.com/G07cha) in [https://github.com/Hacker0x01/react-datepicker/pull/4393](https://togithub.com/Hacker0x01/react-datepicker/pull/4393) #### What's Changed - 🐛 FIX: readability-isMonthinRange by [@​mary139](https://togithub.com/mary139) in [https://github.com/Hacker0x01/react-datepicker/pull/4421](https://togithub.com/Hacker0x01/react-datepicker/pull/4421) - Fix [#​4431](https://togithub.com/Hacker0x01/react-datepicker/issues/4431): Update the excludedDate to match the year to check of the isYearDisabled by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4432](https://togithub.com/Hacker0x01/react-datepicker/pull/4432) - Fix [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): Update home key and end key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4430](https://togithub.com/Hacker0x01/react-datepicker/pull/4430) - Document [#​4420](https://togithub.com/Hacker0x01/react-datepicker/issues/4420): 📝 Update the behavior of Home Key and End Key in the README file by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4438](https://togithub.com/Hacker0x01/react-datepicker/pull/4438) - Fix [#​4076](https://togithub.com/Hacker0x01/react-datepicker/issues/4076): Trigger onCalendarClose event and onChange even when the same date is selected as the start and the end date in a date range by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4394](https://togithub.com/Hacker0x01/react-datepicker/pull/4394) - Excluded dates message by [@​dvelazquez1282](https://togithub.com/dvelazquez1282) in [https://github.com/Hacker0x01/react-datepicker/pull/4437](https://togithub.com/Hacker0x01/react-datepicker/pull/4437) - Fix [#​4456](https://togithub.com/Hacker0x01/react-datepicker/issues/4456): Add shift+pageUp key and shift+pageDown key navigation in Calendar component by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4457](https://togithub.com/Hacker0x01/react-datepicker/pull/4457) - Fix options passed to date-fns/format by [@​emilecantin](https://togithub.com/emilecantin) in [https://github.com/Hacker0x01/react-datepicker/pull/4469](https://togithub.com/Hacker0x01/react-datepicker/pull/4469) #### New Contributors - [@​mary139](https://togithub.com/mary139) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4421](https://togithub.com/Hacker0x01/react-datepicker/pull/4421) - [@​G07cha](https://togithub.com/G07cha) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4393](https://togithub.com/Hacker0x01/react-datepicker/pull/4393) - [@​dvelazquez1282](https://togithub.com/dvelazquez1282) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4437](https://togithub.com/Hacker0x01/react-datepicker/pull/4437) - [@​emilecantin](https://togithub.com/emilecantin) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4469](https://togithub.com/Hacker0x01/react-datepicker/pull/4469) **Full Changelog**: Hacker0x01/react-datepicker@v4.25.0...v5.0.0 ### [`v4.25.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.25.0): 4.25.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.24.0...v4.25.0) #### What's Changed - feature: Add day parameter to renderMonthContent function by [@​omarhoumz](https://togithub.com/omarhoumz) in [https://github.com/Hacker0x01/react-datepicker/pull/4405](https://togithub.com/Hacker0x01/react-datepicker/pull/4405) - Update 'Local Development' instruction of README.md by [@​raceStarter](https://togithub.com/raceStarter) in [https://github.com/Hacker0x01/react-datepicker/pull/4391](https://togithub.com/Hacker0x01/react-datepicker/pull/4391) - Feature [#​4091](https://togithub.com/Hacker0x01/react-datepicker/issues/4091) - Make the Calendar Icon clickable by [@​balajis-qb](https://togithub.com/balajis-qb) in [https://github.com/Hacker0x01/react-datepicker/pull/4417](https://togithub.com/Hacker0x01/react-datepicker/pull/4417) #### New Contributors - [@​omarhoumz](https://togithub.com/omarhoumz) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4405](https://togithub.com/Hacker0x01/react-datepicker/pull/4405) - [@​raceStarter](https://togithub.com/raceStarter) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4391](https://togithub.com/Hacker0x01/react-datepicker/pull/4391) **Full Changelog**: Hacker0x01/react-datepicker@v4.24.0...v4.25.0 ### [`v4.24.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v4.24.0): 4.24.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v4.23.0...v4.24.0) #### What's Changed - containerRef div shouldnt affect styling by [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) in [https://github.com/Hacker0x01/react-datepicker/pull/4384](https://togithub.com/Hacker0x01/react-datepicker/pull/4384) - Fix: reflect the `holidays` prop change by [@​shimech](https://togithub.com/shimech) in [https://github.com/Hacker0x01/react-datepicker/pull/4373](https://togithub.com/Hacker0x01/react-datepicker/pull/4373) - Disable clear button when the component is disabled by [@​Rafatcb](https://togithub.com/Rafatcb) in [https://github.com/Hacker0x01/react-datepicker/pull/4392](https://togithub.com/Hacker0x01/react-datepicker/pull/4392) #### New Contributors - [@​joaopaulo-capy](https://togithub.com/joaopaulo-capy) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4384](https://togithub.com/Hacker0x01/react-datepicker/pull/4384) - [@​shimech](https://togithub.com/shimech) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4373](https://togithub.com/Hacker0x01/react-datepicker/pull/4373) - [@​Rafatcb](https://togithub.com/Rafatcb) made their first contribution in [https://github.com/Hacker0x01/react-datepicker/pull/4392](https://togithub.com/Hacker0x01/react-datepicker/pull/4392) **Full Changelog**: Hacker0x01/react-datepicker@v4.23.0...v4.24.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
Currently the calendar is being rendered wrapped in a div that the sole intent, as i understand, is to wrap a ref arround it.
Considering this and that there are no props to style that div, it should have the display contents property to not affect styling. In some very specific cases it can create issues, for example in the print below, there is a little gap under the calendar*
*Maybe if i used height 100% in the calendar style it would fix it, however it could introduce other issues in the way i want the style to behave.
With a flex parent: