Fix: reflect the holidays prop change

[shimech]

Issue

The holidays prop is not reflected even if it is updated after initial rendering, because holidays is managed by state, and it is set at only initial rendering.
fix #4372

Fixing Approach

Calculate holidays at every rendering instead of managing it in state

Cons

If very large holidays is given, rendering cost will increase.

[pullrequest]

✅ This pull request was sent to the PullRequest network.

---

@shimech you can click here to see the review status or cancel the code review job.

[pullrequest]

PullRequest Breakdown

Reviewable lines of change

+ 11
- 14

100% JavaScript

Type of change

Fix - These changes are likely to be fixing a bug or issue.

[pullrequest]

This change looks good and simple enough.

Jacques

---

Reviewed with ❤️ by PullRequest

[pullrequest]

the change looks good to me and matches the description. The author has pointed out that if the holiday data becomes large, it might make sense to only call this when state information changes but that would need much more additional logics, so I feel the current implement is sufficient and simple

Xiaoyong W

---

Reviewed with ❤️ by PullRequest

[codecov]

Codecov Report

Merging #4373 (ec46451) into main (89d321f) will increase coverage by 0.04%.
The diff coverage is 42.85%.

❗ Current head ec46451 differs from pull request most recent head 9fd0259. Consider uploading reports for the commit 9fd0259 to get more accurate results

@@            Coverage Diff             @@
##             main    #4373      +/-   ##
==========================================
+ Coverage   96.67%   96.71%   +0.04%     
==========================================
  Files          27       27              
  Lines        2374     2374              
  Branches      966      966              
==========================================
+ Hits         2295     2296       +1     
+ Misses         79       78       -1     

Files	Coverage Δ
src/index.jsx	94.64% <42.85%> (+0.21%)	⬆️

[pullrequest]

PullRequest reviewed the updates made to #4373 since our last review was posted. This includes comments that have been posted by non-PullRequest reviewers. No further issues were found.

Reviewed by:

Xiaoyong W

[pullrequest]

✖️ This code review was cancelled. See Details

[shimech]

Thank you for your review.
Is there anything left for me to do to get this PR merged?