Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default props #4324

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix default props #4324

merged 1 commit into from
Oct 17, 2023

Conversation

dygy
Copy link

@dygy dygy commented Oct 17, 2023

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


@dygy you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 1
- 5

100% JavaScript

Type of change

Fix - These changes are likely to be fixing a bug or issue.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #4324 (dc366f5) into main (892586b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head dc366f5 differs from pull request most recent head dc92a79. Consider uploading reports for the commit dc92a79 to get more accurate results

@@            Coverage Diff             @@
##             main    #4324      +/-   ##
==========================================
- Coverage   96.63%   96.63%   -0.01%     
==========================================
  Files          27       27              
  Lines        2376     2375       -1     
  Branches      967      968       +1     
==========================================
- Hits         2296     2295       -1     
  Misses         80       80              
Files Coverage Δ
src/calendar_icon.jsx 100.00% <100.00%> (ø)

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little refactor! Ship it!

             /|~~~   
           ///|      
         /////|      
       ///////|      
     /////////|      
   \==========|===/  
~~~~~~~~~~~~~~~~~~~~~

Image of Steven S Steven S


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a simple straightforward change fixing default className to empty string and looks good

Image of Xiaoyong W Xiaoyong W


Reviewed with ❤️ by PullRequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants