Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure Proper Date Selection in DatePicker Test Case #4284

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Fix: Ensure Proper Date Selection in DatePicker Test Case #4284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions test/datepicker_test.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,24 @@ function getSelectedDayNode(datePicker) {
);
}

function findSelectedDay(datePicker, targetDate) {
const days = TestUtils.scryRenderedComponentsWithType(datePicker, Day);
return days.find(
(d) =>
utils.formatDate(d.props.day, "yyyy-MM-dd") ===
utils.formatDate(targetDate, "yyyy-MM-dd"),
);
}

function goToLastMonth(datePicker) {
const lastMonthButton = TestUtils.scryRenderedDOMComponentsWithClass(
datePicker,
"react-datepicker__navigation-icon--previous",
)[0];

TestUtils.Simulate.click(ReactDOM.findDOMNode(lastMonthButton));
}

describe("DatePicker", () => {
afterEach(() => {
jest.resetAllMocks();
Expand Down Expand Up @@ -1688,7 +1706,8 @@ describe("DatePicker", () => {
const onChange = (dates = []) => {
[startDate, endDate] = dates;
};
let datePicker = TestUtils.renderIntoDocument(

const datePicker = TestUtils.renderIntoDocument(
<DatePicker
selected={selected}
onChange={onChange}
Expand All @@ -1698,12 +1717,15 @@ describe("DatePicker", () => {
inline
/>,
);
let days = TestUtils.scryRenderedComponentsWithType(datePicker, Day);
const selectedDay = days.find(
(d) =>
utils.formatDate(d.props.day, "yyyy-MM-dd") ===
utils.formatDate(selectedPrevious, "yyyy-MM-dd"),
);

let selectedDay = findSelectedDay(datePicker, selectedPrevious);
// Ensure that we're dealing with a date at the beginning of the month
if (!selectedDay) {
// If it's the beginning of the month & if the selectedPrevious is not being displayed, navigate to the previous month and reselect the selectedPrevious
goToLastMonth(datePicker);
selectedDay = findSelectedDay(datePicker, selectedPrevious);
}

TestUtils.Simulate.click(ReactDOM.findDOMNode(selectedDay));
expect(utils.formatDate(startDate, "yyyy-MM-dd")).toBe(
utils.formatDate(selectedPrevious, "yyyy-MM-dd"),
Expand Down
Loading