Improve focus with portals #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using portals, tab moves focus out of datepicker but leaves portal open. Without portal, user can still enter the picker with arrow keys. Tabbing through the datepicker should not land the user into a tab trap. closes Hacker0x01#3522
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@Sam-Apostel you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
The majority of the chnages is prettier updates, that said the one functional change looks good and no issues are noted.
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
This appears to be a straightforward change that matches the PR description. Nice work!
Reviewed with ❤️ by PullRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes focus behaviour to fix portal usage.
Using portals, tab moves focus out of datepicker but leaves portal open.
A check was removed that only closed the portal on Shift + Tab, and replaced with just Tab
Without portal, user can still enter the picker with arrow keys.
Tabbing through a form with a datepicker should not land the user into a tab loop/trap.
closes #3522