-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karma to jest migration completed #4229
karma to jest migration completed #4229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall, would be good to get CI scripts running so we can have the test suite running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network.
@polbene95 you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 2,088
- 2,337
96% JavaScript (tests)
3% JavaScript
1% JSON
<1% Other (tests)
Generated lines of change
+ 1,862
- 693
Type of change
Feature - These changes are adding a new feature or improvement to existing code.
1 Message | |
---|---|
Due to its size, this pull request will be reviewed by PullRequest staff before being sent to the reviewer network, and the team will reach out if there are any concerns. After this pull request is sent to the network, please be aware that it will likely have a longer turnaround time and require multiple passes from our reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this!
I reviewed all the non-test files and it gets a big thumbs up from me.
I skimmed over the new tests and they look good to me as well.
Closes #4107
In this PR we are migrating from Karma to Jest.
Extra changes:
In
day.jsx
,month.jsx
, &week.jsx
PropTypes.instanceOf(Element)
was changed forPropTypes.object
because the first one doesn’t work on server side render making the test fail.In
day.jsx
we changedshouldFocusDay && this.dayEl.current.focus({ preventScroll: true });
forshouldFocusDay && this.dayEl.current?.focus({ preventScroll: true });
because in some testthis.dayEl.current
wasnull
making the test fail.What's missing:
test
,test:ci
&test:watch
need to be updated.