Adds keyboard navigation for month picker #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilaazuma
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2389 +/- ##
==========================================
+ Coverage 92.08% 92.26% +0.18%
==========================================
Files 20 20
Lines 1250 1280 +30
Branches 328 340 +12
==========================================
+ Hits 1151 1181 +30
Misses 40 40
Partials 59 59
Continue to review full report at Codecov.
|
camilaazuma
force-pushed
the
fix/acessibility-month
branch
from
b4c1157 to
ba00418
Compare
Co-authored-by: Jonas Antonelli <[email protected]>
|
Woohoo, nice work! Thanks for creating this PR! |
This was referenced Dec 8, 2020
p-rogas
pushed a commit
to p-rogas/react-datepicker
that referenced
this pull request
Mar 22, 2023
* feat: adds basic keyboard navigation to month picker * fix: set focus when navigating through keyboard * feat: add aria label to months * fix: prevent navigation to disabed/excluded months * tests: Tests added for new Month Picker feature * docs: updates readme with new keybinds * test: test coverage improved * Update src/month.jsx Co-authored-by: Jonas Antonelli <[email protected]> Co-authored-by: Jonas Antonelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: