Range on one datepicker for #584 #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* transfer prop for it through parents components to children * add logic for getting styles for range
Codecov Report
@@ Coverage Diff @@
## master #2204 +/- ##
==========================================
+ Coverage 91.98% 92.10% +0.12%
==========================================
Files 20 20
Lines 1223 1242 +19
Branches 312 324 +12
==========================================
+ Hits 1125 1144 +19
Misses 40 40
Partials 58 58
Continue to review full report at Codecov.
|
* remove extra code * add tests * add condition check for set same date when selectsRange
|
Thanks for adding support for this! |
p-rogas
pushed a commit
to p-rogas/react-datepicker
that referenced
this pull request
Mar 22, 2023
* add logic for getting date range * transfer prop for it through parents components to children * add logic for getting styles for range * add tests for selectsRange prop * add example of using selectsRange prop to docs-site * refactoring * remove extra code * add tests * add condition check for set same date when selectsRange * refactore and correct test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to implement one datepicker for range. Thanks to the guys from #584 discussion, their examples are the base for this PR. I hope this will help.