-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YearPicker upgrades #2186
Merged
martijnrusschen
merged 9 commits into
Hacker0x01:master
from
3bOONAL:feature/year_picker_upgrades
Jun 27, 2020
Merged
YearPicker upgrades #2186
martijnrusschen
merged 9 commits into
Hacker0x01:master
from
3bOONAL:feature/year_picker_upgrades
Jun 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rding to previous realisations
…evious realisations
… of year in periods
…d checks with yearsDisabled, transfer all props to Year component, update tests
…y buttons, add styles for it, add tests for next/previous buttons
…into feature/year_picker_upgrades
Thanks, this is great work! |
This was referenced Jun 27, 2020
p-rogas
pushed a commit
to p-rogas/react-datepicker
that referenced
this pull request
Mar 22, 2023
* update forming of year periods, update classnames for datepicker according to previous realisations * update logic of forming years to show, updates styles according to previous realisations * add utils and tests for creating periods of years and checking status of year in periods * update styles according to previous realisations of calendar types * add handling of year picker as previous reallisations of calendar, add checks with yearsDisabled, transfer all props to Year component, update tests * add functionality for correct work with increasing/decreasing years by buttons, add styles for it, add tests for next/previous buttons * refactore renderYearHeader method * add propTypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update work with change year by next/previous buttons,
update render of years with saving position of years,
add preselected year styles,
cover by tests for next/previous buttons and showing periods of years,
add work with min/max dates.
solutions for #2167, #2166, #2154