Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The calendar is missing accessibility properties #4518

Closed
barettjfed opened this issue Feb 15, 2024 · 0 comments · Fixed by qburst/react-datepicker-3#15 or #4549
Closed

The calendar is missing accessibility properties #4518

barettjfed opened this issue Feb 15, 2024 · 0 comments · Fixed by qburst/react-datepicker-3#15 or #4549

Comments

@barettjfed
Copy link
Contributor

Describe the bug
According to the ARIA Authoring Practices guide for W3C the calendar popup should have role="dialog" and aria-modal="true". Without these in place screen readers will not have trapped focus.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any react-datepicker example
  2. Notice that they are missing these properties

Expected behavior
role="dialog" and aria-modal="true" are present on the calendar popup.
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Feb 29, 2024
🔨 Add accessibility props to the Calendar container
ac6daba 
Closes Hacker0x01#4518
This was referenced Feb 29, 2024
Merged
Merged
martijnrusschen added a commit that referenced this issue Feb 29, 2024
@martijnrusschen
Merge pull request #4549 from qburst/issue-4518/fix/aria-accessibilit…
705319a 
…y-calendar

Fix #4518: 🔨 Add accessibility props like role and aria-modal to the Calendar popup
@IrvingYHM IrvingYHM mentioned this issue Jun 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@barettjfed